Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: split tooltip.ts

Download Browse

tooltip.ts is big ball of different functions used to instantiate, fetch, and display tooltips on cross references. In order to be able to update the behavior of this library, this contribution split it in different files so that it will be easier to add tests. Some tests have been added as a best effort, the others are left for the future us. No functional changes, tooltip is still displayed on cross references, on user @ mentions, and in roadmap. Part of story #40114: Cross references in Artidoc Change-Id: I7bee220152c2a7c6fde27c3d101028f5028979b5

+389 −180
Nicolas Terray (nterray) 2024-10-31 11:47
Nicolas Terray (nterray) 2024-10-31 11:51
2e2a4b8e79680be40c5a47c563a695e2f024bc6f
e5f3ac07d13c82f0cee6426ee650fdaf5deada4f
git #tuleap/stable/2e2a4b8e79680be40c5a47c563a695e2f024bc6f

Modified Files

Side by side diff
Inline diff
Name
M lib/frontend/tooltip/package.json +4 −4 Go to diff View file
A lib/frontend/tooltip/src/create-tooltip.ts +140 −0 Go to diff View file
A lib/frontend/tooltip/src/load-tooltips.test.ts +63 −0 Go to diff View file
A lib/frontend/tooltip/src/load-tooltips.ts +43 −0 Go to diff View file
A lib/frontend/tooltip/src/retrieve-tooltip-data.test.ts +91 −0 Go to diff View file
A lib/frontend/tooltip/src/retrieve-tooltip-data.ts +43 −0 Go to diff View file
M lib/frontend/tooltip/src/tooltip.ts +3 −175 Go to diff View file
R lib/frontend/tooltip/src/tooltip.d.ts Go to diff View file
M lib/frontend/tooltip/vite.config.ts +2 −1 Go to diff View file