Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Extract MemberAdder into a dedicated object

Download Browse

Part of story #13490 have a consistent management of project & groups members This will let us add to project members more easily for static, dynamic ugroups, private, public projects How to test: - No functional change expected when adding users to static or dynamic ugroups - No functional change expected in PUT /user_groups/{id}/users Change-Id: Idb353e003e937411b0ba38158d00159f7d21e0d4

+630 −312
Joris MASSON (jmasson) 2019-07-04 18:01
Joris MASSON (jmasson) 2019-07-04 18:35
2e71e5ce43711e092027e95f0eddef8c5266f1bd
57b060ac9a2c8a1bfcb24c9fb7148edf109e507f
git #tuleap/stable/2e71e5ce43711e092027e95f0eddef8c5266f1bd

Modified Files

Side by side diff
Inline diff
Name
M src/common/Project/ProjectUGroup.php +13 −43 Go to diff View file
A src/common/Project/UGroups/Membership/InvalidProjectException.php +27 −0 Go to diff View file
A src/common/Project/UGroups/Membership/MemberAdder.php +86 −0 Go to diff View file
A src/common/Project/UGroups/Membership/MembershipUpdateVerifier.php +46 −0 Go to diff View file
A src/common/Project/UGroups/Membership/StaticUGroups/StaticMemberAdder.php +41 −0 Go to diff View file
A src/common/Project/UGroups/Membership/UserIsAnonymousException.php +27 −0 Go to diff View file
D tests/phpunit/common/Project/ProjectUGroupTest.php +0 −68 Go to diff View file
A tests/phpunit/common/Project/UGroups/Membership/MemberAdderTest.php +151 −0 Go to diff View file
A tests/phpunit/common/Project/UGroups/Membership/MembershipUpdateVerifierTest.php +89 −0 Go to diff View file
M tests/simpletest/common/Project/UGroupTest.php +150 −201 Go to diff View file