Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: vuex store -> provide/inject for report state

Download Browse

part of story #38263 Choose my own columns based on field name (numeric, text, dates) How to test: - No functional change expected with or without the feature flag tuleap config-set feature_flag_enable_tql_select 1 - Editing the query, saving the report and cancelling both should function as before. Why? We do not need a full Vuex (or Pinia) store for the Cross-tracker widget, there are only a handful truly "global" pieces of data. Using provide/inject can fully replace it. The display of the CSV export button depends on Vuex store, my goal is to fully replace it by provide/inject in order to avoid adding more code that depends on Vuex store in the new SelectableTable. Change-Id: Ie8e13d3f40b80c123de5ca133baa07e2ca76afed

+215 −216
Joris MASSON (jmasson) 2024-07-26 10:39
Joris MASSON (jmasson) 2024-07-26 11:57
2ef48cc33c9b1a54490b87ead83f756a9dc5f424
8b1f6f287486ae03eab81ce7dc1f51a9eb4f48d5
git #tuleap/stable/2ef48cc33c9b1a54490b87ead83f756a9dc5f424

Modified Files

Side by side diff
Inline diff
Name
M plugins/crosstracker/scripts/cross-tracker/src/CrossTrackerWidget.test.ts +89 −61 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/CrossTrackerWidget.vue +36 −15 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/components/selectable-table/SelectableTable.test.ts +13 −13 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/components/selectable-table/SelectableTable.vue +6 −9 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/components/table/ArtifactTable.test.ts +11 −9 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/components/table/ArtifactTable.vue +8 −10 Go to diff View file
A plugins/crosstracker/scripts/cross-tracker/src/domain/ReportState.ts +20 −0 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/injection-symbols.ts +4 −1 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/reading-mode/ReadingMode.test.ts +12 −10 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/reading-mode/ReadingMode.vue +12 −11 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/store/index.ts +0 −2 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/store/mutations.test.ts +3 −55 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/store/mutations.ts +1 −18 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/type.ts +0 −2 Go to diff View file