Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

chore: Distinguish the current project and any project

Download Browse

No functional change expected. Notes: In git #tuleap/stable/a5efa9663b116920dabe1c69d18b7145fe2e00de, we introduced a proxy that creates arbitrary ProjectIdentifiers from a selectbox fed with data from the REST API. We should take care to distinguish between arbitrary Project ids and the current project id. Only the current project id may be used to preview markdown text (for example when writing a new follow-up comment). We should not allow passing just any project id, it is meant to be called with the current project id. Using two separate identifier types will prevent that. part of story #28823 [modal] create artifact Change-Id: Ic9f9cf9fb4a7160cdb4d675b7f9d9990dd251085

+63 −14
Joris MASSON (jmasson) 2023-06-07 10:40
Joris MASSON (jmasson) 2023-06-07 10:42
2f3293c0d0e6bb73d31c7b76788a3cc8f7697788
be558a80049f6568ca3371c54609a9f7aa84feea
git #tuleap/stable/2f3293c0d0e6bb73d31c7b76788a3cc8f7697788

Modified Files

Side by side diff
Inline diff
Name
R plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/ProjectIdentifierProxy.test.ts Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/src/adapters/REST/ProjectIdentifierProxy.ts Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/comments/ModalCommentsSection.test.ts +2 −2 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/creation/ArtifactCreatorElement.ts +2 −2 Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/creation/ProjectIdentifierTrackerCreationProxy.test.ts Go to diff View file
R plugins/tracker/scripts/lib/artifact-modal/src/adapters/UI/fields/link-field/creation/ProjectIdentifierTrackerCreationProxy.ts Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/src/domain/CurrentProjectIdentifier.ts +23 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/ProjectIdentifier.ts +0 −1 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/comments/CommentsController.test.ts +2 −2 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/domain/comments/CommentsController.ts +4 −4 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/src/tuleap-artifact-modal-controller.js +2 −2 Go to diff View file
A plugins/tracker/scripts/lib/artifact-modal/tests/stubs/CurrentProjectIdentifierStub.ts +27 −0 Go to diff View file
M plugins/tracker/scripts/lib/artifact-modal/tests/stubs/ProjectIdentifierStub.ts +1 −1 Go to diff View file