Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Move creation of cross references out of processor

Download Browse

Refactoring. No functional changes are expected. The creation of cross references deserves a dedicated object to reduce the responsibilities of PostMergeRequestWebhookActionProcessor. Part of story #17182: reference tuleap artifacts in gitlab merge requests Change-Id: I912763254f60ae5b3cda41b56855a782d81988c1

+556 −127
Nicolas Terray (nterray) 2021-01-28 10:07
Nicolas Terray (nterray) 2021-01-28 10:07
2f783ffc8acb340f7c7e6e9c72187d3d5d3d4cf9
d4149891ee9a242df722e504a2d8c8a6890204d1
git #tuleap/stable/2f783ffc8acb340f7c7e6e9c72187d3d5d3d4cf9

Modified Files

Side by side diff
Inline diff
Name
A plugins/gitlab/include/Repository/Webhook/PostMergeRequest/CrossReferenceFromMergeRequestCreator.php +155 −0 Go to diff View file
M plugins/gitlab/include/Repository/Webhook/PostMergeRequest/PostMergeRequestWebhookActionProcessor.php +17 −121 Go to diff View file
M plugins/gitlab/include/gitlabPlugin.php +7 −3 Go to diff View file
A plugins/gitlab/tests/unit/Repository/Webhook/PostMergeRequest/CrossReferenceFromMergeRequestCreatorTest.php +371 −0 Go to diff View file
M plugins/gitlab/tests/unit/Repository/Webhook/PostMergeRequest/PostMergeRequestWebhookActionProcessorTest.php +6 −3 Go to diff View file