stable

Clone or download

Read-only

fix: list buttons do no work as expected

Part of story #38627: Choice of a new Rich Text Editor There are several issues with the list buttons: 1. Faulty buttons states When we select one item of a list, then the corresponding button in the toolbar is activated: OK. However, when we select more than one item of the same list, the button is not marked as active: KO 2. Impossible to sink list items by clicking on the active list button When one or more items of the same list are selected, then clicking on the list button should sink the selected list items. Currently, cliking on the button does nothing: KO How to test: 1. - Create a bullet list and an ordered list - Write some free text below them - Select one or more items in the bullet list --> The bullet list button is activated --> The ordered list button is disabled - Select the last item of the bullet list AND the first item of the ordered list --> both list buttons are disabled - Select one or more items in the ordered list --> The ordered list button is activated --> The bullet list button is disabled - Select the last item of the ordered list AND the free text below it --> both list buttons are disabled - Select the free text --> both list buttons are enabled 2. - Select some list items and click on the list button --> The list items are sinked (1 level) Change-Id: I25a78a9bc44b9de068ed5a656f1a22515481afb8

Modified Files

Name
M lib/frontend/prose-mirror-editor/src/plugins/toolbar/helper/MonoToolbarActionActivator.ts +4 −13 Go to diff View file
M lib/frontend/prose-mirror-editor/src/plugins/toolbar/index.ts +8 −2 Go to diff View file
M lib/frontend/prose-mirror-editor/src/plugins/toolbar/keymap.ts +20 −20 Go to diff View file
D lib/frontend/prose-mirror-editor/src/plugins/toolbar/list/IsListChecker.ts +0 −37 Go to diff View file
M lib/frontend/prose-mirror-editor/src/plugins/toolbar/list/ListInserter.test.ts +9 −10 Go to diff View file
M lib/frontend/prose-mirror-editor/src/plugins/toolbar/list/ListInserter.ts +4 −6 Go to diff View file
M lib/frontend/prose-mirror-editor/src/plugins/toolbar/list/ListStateBuilder.test.ts +25 −15 Go to diff View file
M lib/frontend/prose-mirror-editor/src/plugins/toolbar/list/ListStateBuilder.ts +9 −7 Go to diff View file
A lib/frontend/prose-mirror-editor/src/plugins/toolbar/list/ListsInSelectionDetector.test.ts +67 −0 Go to diff View file
R lib/frontend/prose-mirror-editor/src/plugins/toolbar/list/IsSelectionAListWithTypeChecker.ts Go to diff View file
A lib/frontend/prose-mirror-editor/src/plugins/toolbar/list/SingleListInSelectionDetector.test.ts +141 −0 Go to diff View file
A lib/frontend/prose-mirror-editor/src/plugins/toolbar/list/SingleListInSelectionDetector.ts +46 −0 Go to diff View file
R lib/frontend/prose-mirror-editor/src/plugins/toolbar/list/stubs/IsSelectionAListChecker.ts Go to diff View file
R lib/frontend/prose-mirror-editor/src/plugins/toolbar/list/stubs/IsSelectionAListWithTypeChecker.ts Go to diff View file
M lib/frontend/prose-mirror-editor/src/plugins/toolbar/mono-toolbar.ts +19 −12 Go to diff View file