Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refacto: make ProgramManagementXMLConfig constructor private

Download Browse

part of: story #22210 select SAFe templates at project creation The goal of this refactoring is to isolate ProgramManagementXMLConfig attributes in order to prevent their modification with values different than the one extracted from the source XML file. No functional change expected Change-Id: Ib0999ac9586dfc97c3129c9dcea8fc3f8a3d88fb

+623 −267
Thomas Gorka (tgorka) 2021-07-29 17:17
Thomas Gorka (tgorka) 2021-07-30 09:27
32163b5055fda3889ef08ad2a9e61d9ab94e3445
f4fe8382edb0c15f5d06dd16e21c921e760b7e36
git #tuleap/stable/32163b5055fda3889ef08ad2a9e61d9ab94e3445

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/Adapter/XML/ProgramManagementConfigXMLImporter.php +13 −4 Go to diff View file
M plugins/program_management/include/Domain/XML/ExtractXMLConfig.php +18 −10 Go to diff View file
A plugins/program_management/include/Domain/XML/ParseXMLConfig.php +34 −0 Go to diff View file
M plugins/program_management/include/Domain/XML/ProgramManagementXMLConfig.php +28 −1 Go to diff View file
M plugins/program_management/include/Domain/XML/ProgramManagementXMLConfigExtractor.php +18 −78 Go to diff View file
A plugins/program_management/include/Domain/XML/ProgramManagementXMLConfigParser.php +57 −0 Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +2 −0 Go to diff View file
M plugins/program_management/tests/unit/Adapter/XML/ProgramManagementConfigXMLImporterTest.php +23 −15 Go to diff View file
M plugins/program_management/tests/unit/Domain/XML/ProgramManagementXMLConfigExtractorTest.php +176 −84 Go to diff View file
A plugins/program_management/tests/unit/Domain/XML/ProgramManagementXMLConfigParserTest.php +57 −0 Go to diff View file
A plugins/program_management/tests/unit/Domain/XML/ProgramManagementXMLConfigTest.php +60 −0 Go to diff View file
M plugins/program_management/tests/unit/Domain/XML/__fixtures/invalid_xml/program-management-config.xml +0 −19 Go to diff View file
M plugins/program_management/tests/unit/Domain/XML/__fixtures/valid_xml/program-management-config.xml +0 −19 Go to diff View file
D plugins/program_management/tests/unit/Domain/XML/__fixtures/with_customisation_xml/program-management-config.xml +0 −17 Go to diff View file
M plugins/program_management/tests/unit/Stub/ExtractXMLConfigStub.php +70 −20 Go to diff View file
A plugins/program_management/tests/unit/Stub/ParseXMLConfigStub.php +67 −0 Go to diff View file