Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: extendable-error -> Result

Download Browse

part of story #38263 Choose my own columns based on field name (numeric, text, dates) - When you try to select more than 25 trackers, it should show an error message as before. You can edit the value in writing-cross-tracker-report to ease the test. - No functional change expected with or without the feature flag tuleap config-set feature_flag_enable_tql_select 1 Why? We used extendable-error in 2017 when it was not safe to extend `Error` and we did not know yet about Results. Using Result, we can better signal that adding a tracker can fail, and using Fault, we can write a dedicated translated message without direct dependency on the Fault type. Change-Id: If3172c755cc8fe256736942c449bcee5797ba746

+17 −40
Joris MASSON (jmasson) 2024-07-30 11:02
Joris MASSON (jmasson) 2024-07-30 11:26
322feb6dc16e721818d63c9f10367a2f357cf358
211cf41306f206d121353c0e0b1e86443a408c17
git #tuleap/stable/322feb6dc16e721818d63c9f10367a2f357cf358

Modified Files

Side by side diff
Inline diff
Name
M plugins/crosstracker/scripts/cross-tracker/package.json +0 −1 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/pnpm-lock.yaml +0 −7 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/WritingMode.test.ts +6 −7 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/WritingMode.vue +3 −15 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/writing-cross-tracker-report.ts +8 −10 Go to diff View file