Part of request #10396: Plugins hooks clean up The default callback for a hook is the hook name. This means that for the following code: $this->addHook('my_event'); I must declare the following method: public function my_event() {} Which is not PSR2 compatible because the name of the method is not in camel case. A workaround is to give the callback when we register the hook: $this->addHook('my_event', 'myEvent'); … public function myEvent() {} Which is not really nice for the developers. In order to fix that, this commit introduces the convention (over configuration) that the hook must be implemented by a callback with the same name, but in camel case. This means: $this->addHook('my_event'); … public function myEvent() {} Of course this change is backward compatible, we can still give the callback in arguments if needed and previous implementations of hooks don't need to change. However after this commit, there is no valid reasons that new code added in plugin are not compatible with PSR2. Change-Id: Ide2bf58345050cbd3f5ef3a6f33e0bd3038072bf

+146 −67

Author

Nicolas Terray (nterray) 2017-07-01 23:39

Committer

Nicolas Terray (nterray) 2017-07-04 15:47

Hash 32a3d453f78afd3550f4e8660a12f21f033a4879

Parent 039b05c9ef0f6695e0113fcb3c3680f380afaa8c

Reference git #tuleap/stable/32a3d453f78afd3550f4e8660a12f21f033a4879