Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: TypeScript warnings at build step in `@tuleap/plugin-pullrequest-comments`

Download Browse

Closes request #38629 TypeScript warnings during build in @tuleap/plugin-pullrequests-comments How to test: - run `pnpm --filter @tuleap/commonmark-popover build` - run `pnpm --filter @tuleap/plugin-pullrequest-comments build` --> No warnings are displayed --> No functional changes in the pull-request overview and file-diff apps Change-Id: Iea8eb667581c0fcb4bd2217ff7c3bf20f044e5e9

+21 −24
Thomas Gorka (tgorka) 2024-06-24 14:15
Thomas Gorka (tgorka) 2024-06-24 14:54
32a56ff2e1e655d90d7e4bb460cc98efd833ed00
d4a6475f76b3b4ff341d6b9a4c59f0ddedcc1ce1
git #tuleap/stable/32a56ff2e1e655d90d7e4bb460cc98efd833ed00

Modified Files

Side by side diff
Inline diff
Name
M lib/frontend/commonmark-popover/src/index.ts +1 −1 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/comment-reply/PullRequestCommentReply.ts +1 −1 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/edition/EditionForm.ts +2 −1 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/main.ts +3 −4 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/description-comment/PullRequestDescriptionComment.ts +1 −1 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/description-comment/main.ts +3 −4 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/new-comment-form/NewCommentForm.ts +1 −1 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/new-comment-form/main.ts +3 −4 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/skeleton/PullRequestCommentSkeleton.ts +1 −1 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/skeleton/main.ts +3 −4 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/timeline-event/TimelineEvent.ts +1 −1 Go to diff View file
M plugins/pullrequest/scripts/lib/pullrequest-comments/src/timeline-event/main.ts +1 −1 Go to diff View file