Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

feat: Remove dependencies w/o title|timeframe semantic

Download Browse

If an artifact linked to a task has no title or timeframe semantic, then it will never be displayed in the gantt chart (as a task or as a subtask). Therefore there is no need to return it in the collection of dependencies. While it had no impact on the display of links, there was visible consequences for the display of children: a caret was displayed even if no children could be displayed. Even if the current proposal does not fix every edges cases, it has the merit to prevent the display of the caret for the more common situation: a child tracker without needed semantic. Other scenarii like the lack of needed permission to read the artifact, or an artifact with start date > end date is more complex and does not worth it for the Roadmap MVP. Part of story #20979: Display children in Roadmap Change-Id: I9d3da98dadb7e5f24947932fce6720b359f32ff0

+84 −37
Nicolas Terray (nterray) 2021-05-11 12:39
Nicolas Terray (nterray) 2021-05-11 16:07
32fe7661793f8e1d50ef7c04c2b84c8f86fb0879
b758ab77df5d394f96cf7b79f7415e826feb4ef5
git #tuleap/stable/32fe7661793f8e1d50ef7c04c2b84c8f86fb0879

Modified Files

Side by side diff
Inline diff
Name
A plugins/roadmap/include/Roadmap/NatureForRoadmapDao.php +48 −0 Go to diff View file
M plugins/roadmap/include/Roadmap/REST/v1/DependenciesRetriever.php +20 −14 Go to diff View file
M plugins/roadmap/include/Roadmap/REST/v1/RoadmapResource.php +2 −1 Go to diff View file
M plugins/roadmap/include/Roadmap/REST/v1/TasksResource.php +2 −1 Go to diff View file
M plugins/roadmap/tests/unit/Roadmap/REST/v1/DependenciesRetrieverTest.php +12 −21 Go to diff View file