Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Fix current pane for references pane

Download Browse

Part of story #10061 new project admin homepage and navigation When you go to project » admin » references and you try to add or edit a reference, then the tab "References" should be active. We should not rely on a url parameter to know if a pane is selected or not. As soon as we enter in the labels controller or the references controller, we know that we are in the corresponding tab. Using an url parameter is bad because it induces duplication and is error prone. This commit applies this approach only for burning parrot pages, and for references administration. Changing the pattern for every flaming parrot pages would clutter too much the review, therefore we must let a default parameter in project_admin_header() until we fix other pages :/ Change-Id: I55c7a2b8720108d92466eaaf8dac4d8aadf79725

+25 −20
Nicolas Terray (nterray) 2017-10-31 09:22
Nicolas Terray (nterray) 2017-10-31 11:46
32ff0e020ce455dc6fba24219c7fb67b854be403
e95aa4e40a5fdcc6b7e414d59ae883b8607c13dd
git #tuleap/stable/32ff0e020ce455dc6fba24219c7fb67b854be403

Modified Files

Side by side diff
Inline diff
Name
M src/common/project/Admin/Navigation/HeaderNavigationDisplayer.php +6 −6 Go to diff View file
M src/common/project/Admin/Navigation/NavigationPresenterBuilder.php +6 −5 Go to diff View file
M src/common/project/Admin/ProjectDetails/ProjectDetailsController.php +1 −1 Go to diff View file
M src/common/project/Label/IndexController.php +1 −1 Go to diff View file
M src/www/project/admin/include/ReferenceAdministrationViews.class.php +8 −3 Go to diff View file
M src/www/project/admin/index.php +1 −2 Go to diff View file
M src/www/project/admin/project_admin_utils.php +2 −2 Go to diff View file