stable

Clone or download

Read-only

refactor: Naming in TrackerDatabaseBuilder

part of request #40099 Cross-Tracker search finishing touches 16.1 No functional change. DB integration tests should pass. Why? It was not obvious in "setReadPermission" that it was a method for Tracker fields. Also the "set" implies that you can set it to true or false. By using "grant", I'm hoping to make it clear that it gives the permission, you cannot set it false (it means deleting from the table). I also took the opportunity to replace "addStatusValueForArtifact" by "buildListValue" which does the same thing. I also used list instead of [] for types, it is stricter. Change-Id: Id21d4eb4cafbdf116198055f54229d65224e8ee8

Modified Files

Name
M plugins/agiledashboard/tests/integration/Milestone/Sidebar/MilestoneDaoTest.php +18 −18 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/DuckTypedField/DateDuckTypedFieldTest.php +3 −3 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/DuckTypedField/DatetimeDuckTypedFieldTest.php +3 −3 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/DuckTypedField/NumericDuckTypedFieldTest.php +3 −3 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/DuckTypedField/OpenStaticListDuckTypedFieldTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/DuckTypedField/OpenUGroupListDuckTypedFieldTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/DuckTypedField/OpenUserListDuckTypedFieldTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/DuckTypedField/StaticListDuckTypedFieldTest.php +3 −3 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/DuckTypedField/TextDuckTypedFieldTest.php +3 −3 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/DuckTypedField/UGroupListDuckTypedFieldTest.php +3 −3 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/DuckTypedField/UserListDuckTypedFieldTest.php +3 −3 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Metadata/ArtifactIdMetadataTest.php +1 −1 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Metadata/AssignedToMetadataTest.php +3 −3 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Metadata/DescriptionMetadataTest.php +3 −3 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Metadata/LastUpdateByMetadataTest.php +1 −1 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Metadata/LastUpdateDateMetadataTest.php +1 −1 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Metadata/StatusMetadataTest.php +3 −3 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Metadata/SubmittedByMetadataTest.php +1 −1 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Metadata/SubmittedOnMetadataTest.php +1 −1 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Metadata/TitleMetadataTest.php +3 −3 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/OrderBy/AssignedToOrderByBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/OrderBy/DateOrderByBuilderTest.php +1 −1 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/OrderBy/DatetimeOrderByBuilderTest.php +1 −1 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/OrderBy/DescriptionOrderByBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/OrderBy/NumericOrderByBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/OrderBy/StaticListOrderByBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/OrderBy/StatusOrderByBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/OrderBy/TextOrderByBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/OrderBy/TitleOrderByBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/OrderBy/UGroupListOrderByBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/OrderBy/UserListOrderByBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/ArtifactIdSelectBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/ArtifactSelectTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/AssignedToSelectBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/DateSelectBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/DescriptionSelectBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/LastUpdateBySelectBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/LastUpdateDateSelectBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/NumericSelectBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/PrettyTitleSelectBuilderTest.php +4 −4 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/ProjectNameSelectBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/StaticListSelectBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/StatusSelectBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/SubmittedBySelectBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/SubmittedOnSelectBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/TextSelectFromBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/TitleSelectBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/TrackerNameSelectBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/UGroupListSelectFromBuilderTest.php +2 −2 Go to diff View file
M plugins/crosstracker/tests/integration/CrossTracker/Report/Query/Advanced/Select/UserListSelectFromBuilderTest.php +2 −2 Go to diff View file
M plugins/tracker/tests/integration/Permission/TrackersPermissionsDaoOnArtifactsTest.php +6 −6 Go to diff View file
M plugins/tracker/tests/integration/Permission/TrackersPermissionsDaoOnFieldsTest.php +5 −5 Go to diff View file
M plugins/tracker/tests/integration/Permission/TrackersPermissionsDaoOnTrackersTest.php +2 −2 Go to diff View file
M plugins/tracker/tests/integration/Test/Builders/TrackerDatabaseBuilder.php +10 −21 Go to diff View file