Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: remove usage of SQL_CALC_FOUND_ROWS from getPaginatedPullRequests

Download Browse

part of story #35821 Pull request new home page - Filter on Authors SQL_CALC_FOUND_ROWS is deprecated, so let's use the new way of retrieving the number of rows [0] while we are wxorking in the area. -- No functional change expected [0] https://dev.mysql.com/doc/refman/8.0/en/information-functions.html#function_found-rows Change-Id: I0225dc8fdaaf5facdd5569b3321584919f3826df

+105 −58
Thomas Gorka (tgorka) 2024-01-15 11:38
Thomas Gorka (tgorka) 2024-01-15 17:42
33ed78e8a9571f2f0676c87f32cfb0b8dbf78e89
0291cf1fa5e0b5b1a9ea88147ca3eddd30f1c6ef
git #tuleap/stable/33ed78e8a9571f2f0676c87f32cfb0b8dbf78e89

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/include/PullRequest/Dao.php +30 −34 Go to diff View file
A plugins/pullrequest/include/PullRequest/PullRequestsPage.php +51 −0 Go to diff View file
M plugins/pullrequest/include/PullRequest/REST/v1/RepositoryPullRequests/GETHandler.php +3 −4 Go to diff View file
M plugins/pullrequest/include/PullRequest/SearchPaginatedPullRequests.php +1 −3 Go to diff View file
M plugins/pullrequest/tests/integration/DaoTest.php +14 −10 Go to diff View file
M plugins/pullrequest/tests/unit/Tests/Stub/SearchPaginatedPullRequestsStub.php +6 −7 Go to diff View file