stable

Clone or download

Read-only

request #10482: Improve performance of the page rendering engine

This contribution upgrades the Mustache library to v2.12 Recent versions of the library has improved the tokenizer performance and allow to cache the templates. These improvements yield a nice performance bonus: * in site admin on the system event administration page, I got a ~60% improvement of the execution time (678ms avg -> 272ms avg) * on a tracker report of Bug tracker with few artifacts, I got a ~9% improvement of the execution time (212ms avg -> 192ms avg) Using a recent version will also allow us to use new features of mustache.php, like blocks or helpers. However this new version only supports the default behavior of the mustache specification in case of a variable miss: it silently returns an empty string. Change-Id: I559c2c7d6024cffab20bfced348d404bc0c993c8

Modified Files

Name
M plugins/git/tests/Git/Gitolite/_fixtures/mirrors_gitolite.conf +1 −0 Go to diff View file
M plugins/tests/include/TestsPluginRunner.class.php +8 −7 Go to diff View file
M src/common/autoload.php +4 −9 Go to diff View file
M src/common/include/SiteCache.php +9 −1 Go to diff View file
R src/common/templating/mustache/MustacheDebugException.class.php Go to diff View file
M src/common/templating/TemplateRendererFactory.class.php +16 −19 Go to diff View file
D src/common/templating/mustache/MustacheChainedPathLoader.class.php +0 −97 Go to diff View file
D src/common/templating/mustache/MustacheDebug.class.php +0 −115 Go to diff View file
D src/common/templating/mustache/MustacheDebugRenderer.class.php +0 −45 Go to diff View file
R tests/simpletest/common/templating/mustache/MustacheRendererTest.php Go to diff View file
M src/common/templating/mustache/MustacheRenderer.class.php +19 −39 Go to diff View file
D src/common/templating/mustache/vendor/Mustache.php +0 −911 Go to diff View file
D src/common/templating/mustache/vendor/MustacheLoader.php +0 −86 Go to diff View file
M src/composer.json +2 −1 Go to diff View file
M src/composer.lock +47 −1 Go to diff View file
M src/www/soap/index.php +3 −1 Go to diff View file
M src/www/themes/FlamingParrot/templates/navbar.mustache +1 −1 Go to diff View file
D tests/simpletest/common/templating/TemplateRendererFactoryTest.php +0 −50 Go to diff View file
D tests/simpletest/common/templating/mustache/MustacheDebugRendererTest.php +0 −89 Go to diff View file
D tests/simpletest/common/templating/mustache/templates/invalid-template.mustache +0 −3 Go to diff View file
D tests/simpletest/common/templating/mustache/templates/test.mustache +0 −9 Go to diff View file
D tests/simpletest/common/templating/mustache/templates/tree-item.mustache +0 −8 Go to diff View file
D tests/simpletest/common/templating/mustache/templates/valid-template-with-invalid-partial.mustache +0 −3 Go to diff View file
D tests/simpletest/common/templating/mustache/templates/valid-template.mustache +0 −1 Go to diff View file