stable
Clone or download
Read-only
request #12513: Commits associated with an empty email author address show a wrong author in the web UI
When Tuleap does the association between an commit author and Tuleap user, the commits with empty emails should be left out. Empty strings as emails are in this context not enough to get accurate data. The issue can be reproduced by creating a commit with an empty email and pushing it to a Tuleap repo: $ git -c author.email='' commit -m 'Commit message' $ git push Change-Id: I623b4fb0ab9bce57efebdfb4d05c8aac990d1c17
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/git/include/CommitMetadata/CommitMetadata.php | +14 | −1 | Go to diff View file |
| M | plugins/git/include/CommitMetadata/CommitMetadataRetriever.php | +17 | −9 | Go to diff View file |
| M | plugins/git/include/GitPHP/Commit/CommitPresenter.php | +4 | −6 | Go to diff View file |
| M | plugins/git/include/GitPHP/Commit/CommitUserPresenter.php | +15 | −12 | Go to diff View file |
| M | plugins/git/include/GitPHP/Shortlog/ShortlogCommitPresenter.php | +11 | −9 | Go to diff View file |
| M | plugins/git/include/GitPHP/Shortlog/ShortlogPresenterBuilder.php | +18 | −30 | Go to diff View file |
| M | plugins/git/include/GitPHP/controller/ControllerBase.php | +15 | −1 | Go to diff View file |
| M | plugins/git/include/GitPHP/controller/Controller_Blobdiff.php | +13 | −1 | Go to diff View file |
| M | plugins/git/include/GitPHP/controller/Controller_Commit.php | +13 | −1 | Go to diff View file |
| M | plugins/git/include/GitPHP/controller/Controller_Commitdiff.php | +13 | −1 | Go to diff View file |
| M | plugins/git/include/GitPHP/controller/Controller_History.php | +12 | −2 | Go to diff View file |
| M | plugins/git/include/GitPHP/controller/Controller_Log.php | +12 | −2 | Go to diff View file |
| M | plugins/git/include/GitPHP/controller/Controller_Search.php | +12 | −2 | Go to diff View file |
| M | plugins/git/include/GitPHP/git/ProjectProvider.php | +11 | −1 | Go to diff View file |
| A | plugins/git/phpunit/CommitMetadata/CommitMetadataRetrieverTest.php | +104 | −0 | Go to diff View file |
| M | tests/phpunit/phpunit.xml | +1 | −0 | Go to diff View file |