Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refacto(program-management) Redirections to program_management app

Download Browse

This refactoring is needed before introducing the redirections to the planned-iterations app after an iteration creation/update. The main issues with the existing code were: - Duplication of checks in the pre and post artifact creation/edition hooks - The code in the hooks callbacks are specific to the program_management app. It does not ease the handling of the redirections specific to the iteration creations/updates. It appeared difficult to have hexagonal architecture here since we are in a context of tracker events. If you have a better idea to make the target code better, I'll be glad to consider it. -- No functional change expected part of: story #21385 display Program's iterations Change-Id: Ieedcb578d33a678d777f60c798c988c784807599

+244 −10
Thomas Gorka (tgorka) 2021-11-23 16:37
Thomas Gorka (tgorka) 2021-11-24 16:12
38c0ad91374991b000e52006c384ae6216f51643
d02c9ed83f40d3d282e5a3307b32af700650e1ea
git #tuleap/stable/38c0ad91374991b000e52006c384ae6216f51643

Modified Files

Side by side diff
Inline diff
Name
M plugins/program_management/include/RedirectParameterInjector.php +3 −3 Go to diff View file
R plugins/program_management/include/EventRedirectAfterArtifactCreationOrUpdateHandler.php Go to diff View file
A plugins/program_management/include/RedirectToProgramManagementAppManager.php +64 −0 Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +11 −7 Go to diff View file
A plugins/program_management/tests/unit/RedirectToProgramIncrementAppHandlerTest.php +109 −0 Go to diff View file
A plugins/program_management/tests/unit/RedirectToProgramManagementAppManagerTest.php +57 −0 Go to diff View file