stable
Clone or download
Part of story #9892: notify group of people in addition to individuals User groups that are added manually in the database can be removed from the UI. When the user group is removed, an entry is added in the project history. The user group cannot be added from the UI yet. This commit introduces deprecated method in order to easily have a translated group name. Previous implementations based on ForgeUGroup to have nice looking name seem to be wrong (git permissions, git notifications, …?) since a ForgeUgroup !== ProjectUgroup – by reading the implementation, a ForgeUgroup is a user group that does not belong to a project (group_id IS NULL). There is a dedicated task that will refactor a little bit and will remove the added methods. Change-Id: Ia30d299506e28f477ff4f87fdb1420b9288f2019
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/git/include/Git.class.php | +21 | −2 | Go to diff View file |
| M | plugins/git/include/Git/Notifications/UgroupToBeNotifiedPresenter.php | +3 | −1 | Go to diff View file |
| M | plugins/git/include/Git/Notifications/UgroupsToNotifyDao.php | +13 | −0 | Go to diff View file |
| M | plugins/git/include/GitActions.class.php | +55 | −1 | Go to diff View file |
| M | plugins/git/include/gitPlugin.class.php | +4 | −1 | Go to diff View file |
| M | plugins/git/site-content/fr_FR/LC_MESSAGES/tuleap-git.po | +8 | −0 | Go to diff View file |
| M | plugins/git/site-content/tuleap-git.pot | +8 | −0 | Go to diff View file |
| M | plugins/git/templates/settings/notifications.mustache | +1 | −0 | Go to diff View file |
| M | plugins/git/tests/GitActionsTest.php | +12 | −4 | Go to diff View file |
| M | plugins/git/tests/GitTest.php | +3 | −1 | Go to diff View file |
| M | src/common/dao/UserGroupDao.class.php | +11 | −0 | Go to diff View file |
| M | src/common/user/ForgeUserGroupFactory.php | +11 | −0 | Go to diff View file |