Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Replace class components by Composition API

Download Browse

part of request #40438 Migrate core-platform-admin-banner to Vue 3 No functional change expected in Site admin > Platform Banner page. Notes: Typechecking is not disabled entirely, just "surgically" in tests and in main.ts. Those comments should be removed after switch to Vue 3. Removed all snapshot tests here. They are more effectively replaced by limited assertions that will not break when we change a CSS class or a translated string. Change-Id: I1199de861bd35e42dd40ce08da9fd5b6cbdc3a30

+444 −1085
Joris MASSON (jmasson) 2024-11-07 17:20
Joris MASSON (jmasson) 2024-11-08 09:48
3a12c861031b5c90437480edf6169c2871fd76aa
3180c1a9e75c1f7ba66f153f4360bff22d2c35ac
git #tuleap/stable/3a12c861031b5c90437480edf6169c2871fd76aa

Modified Files

Side by side diff
Inline diff
Name
M src/scripts/platform-admin-banner/jest.config.js +13 −0 Go to diff View file
M src/scripts/platform-admin-banner/package.json +3 −4 Go to diff View file
M src/scripts/platform-admin-banner/pnpm-lock.yaml +6 −27 Go to diff View file
M src/scripts/platform-admin-banner/po/fr_FR.po +6 −7 Go to diff View file
M src/scripts/platform-admin-banner/po/pt_BR.po +2 −3 Go to diff View file
M src/scripts/platform-admin-banner/src/components/App.test.ts +47 −88 Go to diff View file
M src/scripts/platform-admin-banner/src/components/App.vue +64 −85 Go to diff View file
M src/scripts/platform-admin-banner/src/components/BannerPresenter.test.ts +59 −64 Go to diff View file
M src/scripts/platform-admin-banner/src/components/BannerPresenter.vue +111 −108 Go to diff View file
M src/scripts/platform-admin-banner/src/components/ExpirationDateBannerInput.test.ts +1 −1 Go to diff View file
M src/scripts/platform-admin-banner/src/components/ExpirationDateBannerInput.vue +47 −50 Go to diff View file
M src/scripts/platform-admin-banner/src/components/ExpiredBannerInfoMessage.vue +27 −26 Go to diff View file
D src/scripts/platform-admin-banner/src/components/__snapshots__/App.test.ts.snap +0 −126 Go to diff View file
D src/scripts/platform-admin-banner/src/components/__snapshots__/BannerPresenter.test.ts.snap +0 −469 Go to diff View file
D src/scripts/platform-admin-banner/src/components/__snapshots__/ExpirationDateBannerInput.test.ts.snap +0 −11 Go to diff View file
A src/scripts/platform-admin-banner/src/helpers/LocationHelper.ts +39 −0 Go to diff View file
M src/scripts/platform-admin-banner/src/main.ts +10 −13 Go to diff View file
M src/scripts/platform-admin-banner/src/vue.shims.d.ts +3 −2 Go to diff View file
M src/scripts/platform-admin-banner/webpack.common.js +6 −1 Go to diff View file