Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #12872: Document manager should not trust the file size given by the end user

Download Browse

The file size given by the end user should not be trusted blindly. The given value is used in the Content-Length header when downloading the file. As a result, if a wrong size is given the download will considered as corrupted or truncated by browsers/HTTP clients. This contribution fixes the root cause (the given size is not trusted anymore) and ensure files that has been created with a wrong size can still be downloaded. Change-Id: Ic109ac2fd203b147ec41db49d134c6acd2e3c42c

+65 −30
Thomas Gerbet (tgerbet) 2019-01-29 10:33
Thomas Gerbet (tgerbet) 2019-02-04 12:28
3c3828c053b39bb1f408248714b810046fdc7b29
59482176b6760242b054399305b30f9a69181626
git #tuleap/stable/3c3828c053b39bb1f408248714b810046fdc7b29

Modified Files

Side by side diff
Inline diff
Name
M plugins/docman/include/Docman_Actions.class.php +1 −5 Go to diff View file
M plugins/docman/include/soap.php +19 −5 Go to diff View file
M plugins/docman/include/view/Docman_View_Download.class.php +9 −19 Go to diff View file
M plugins/docman/tests/soap/DocmanTest.php +36 −1 Go to diff View file