Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: toolbar flickering when sticky

Download Browse

part of story #38627 Choice of a new Rich Text Editor What is being fixed? In artidoc, there were a bug with the toolbar that produced flickering and positioning issues when popover-menus where open and closed. To avoid it, we had to move the popovers programatically outside of the custom element, so the component height was not recomputed (it somehow was). However, I realized that the issue was in fact due to the lack of an explicit display rule on the webcomponent. -- No functional change expected Change-Id: Icb2ba6cbc6dc9f49bbdd81c23ab04e5a00b7ff89

+15 −40
Thomas Gorka (tgorka) 2024-10-09 14:49
Thomas Gorka (tgorka) 2024-10-09 14:49
3e5e4902040e600a358992860613ea16709dd948
0ea7add33220dba5d5fc6d1ba84c9f022fa4c1b1
git #tuleap/stable/3e5e4902040e600a358992860613ea16709dd948

Modified Files

Side by side diff
Inline diff
Name
M lib/frontend/prose-mirror-editor-toolbar/src/elements/buttons/common/connect-popover.test.ts +8 −22 Go to diff View file
M lib/frontend/prose-mirror-editor-toolbar/src/elements/buttons/common/connect-popover.ts +1 −16 Go to diff View file
M lib/frontend/prose-mirror-editor-toolbar/src/elements/buttons/image/image.ts +2 −1 Go to diff View file
M lib/frontend/prose-mirror-editor-toolbar/src/elements/buttons/link/link.ts +2 −1 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/components/toolbar/EditorToolbar.vue +2 −0 Go to diff View file