Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

request #12945 Legacy language file cache should use VarExporter

Download Browse

8a0b6da02f changed the way language files were cached and loaded due to concurrency issues. From what we can observe with recent caching stuff (front router cache, new hooks) the concurrency issues doesn't seems to be a real problem anymore (even if the correponding php bug is still open). The ~2MB of RAM save on each request is worth another try. It also gives a nice speed-up of ~8% on pages like homepage. Change-Id: I47c9183913c127f7d8eb97e9b9ae7b849bc8f4fd

+305 −325
Manuel Vacelet (vaceletm) 2019-02-01 13:57
Manuel Vacelet (vaceletm) 2019-02-01 16:20
3f5c49570e5504e216f773ae8178cd267c5b445e
6823767f8af8cdd9ba57e9129bd8bee89d6f5c08
git #tuleap/stable/3f5c49570e5504e216f773ae8178cd267c5b445e

Modified Files

Side by side diff
Inline diff
Name
M src/common/language/BaseLanguage.class.php +11 −42 Go to diff View file
A tests/phpunit/common/language/BaseLanguageTest.php +294 −0 Go to diff View file
R tests/simpletest/common/language/_fixtures/etc/plugins/toto/site-content/en_US/.gitkeep Go to diff View file
R tests/simpletest/common/language/_fixtures/etc/site-content/ja_JP/ja_JP.tab Go to diff View file
R tests/simpletest/common/language/_fixtures/extra_path/bla/site-content/en_US/.gitkeep Go to diff View file
R tests/simpletest/common/language/_fixtures/codendi/plugins/toto/site-content/en_US/toto.tab Go to diff View file
R tests/simpletest/common/language/_fixtures/codendi/site-content/en_US/common.tab Go to diff View file
R tests/simpletest/common/language/_fixtures/codendi/site-content/en_US/empty-lines.tab Go to diff View file
R tests/simpletest/common/language/_fixtures/codendi/site-content/en_US/en_US.tab Go to diff View file
R tests/simpletest/common/language/_fixtures/codendi/site-content/en_US/file.tab Go to diff View file
R tests/simpletest/common/language/_fixtures/codendi/site-content/en_US/include.tab Go to diff View file
R tests/simpletest/common/language/_fixtures/codendi/site-content/en_US/only-comments.tab Go to diff View file
R tests/simpletest/common/language/_fixtures/codendi/site-content/fr_FR/fr_FR.tab Go to diff View file
D tests/simpletest/common/language/BaseLanguageTest.php +0 −283 Go to diff View file