Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Group File invalid checks together

Download Browse

part of story #10710 search on fields with duck typing No functional change. CI should be happy. Why? This is part of a refactoring to transition away from invalid checks being grouped by comparison type (equals, lesser than, etc.). We want to group it by field type instead, as it is easier to understand. Most of the time, we work "field by field", so it makes more sense to have all the business rules for a given field in as few files as possible, instead of having all the business rules for "equals" comparison being grouped together. Change-Id: I4f404df13c76e1755b2da65d8349d03e924868c7

+173 −180
Joris MASSON (jmasson) 2024-02-26 11:16
Joris MASSON (jmasson) 2024-02-27 09:57
402289151e9ab2b8ad47c8823395c3228b0ec90d
b021dfbe21aaf522cf673766b927e9d9dc0e7937
git #tuleap/stable/402289151e9ab2b8ad47c8823395c3228b0ec90d

Modified Files

Side by side diff
Inline diff
Name
M plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/InvalidTermCollectorVisitor.php +2 −0 Go to diff View file
M plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/InvalidTermCollectorVisitorTest.php +28 −0 Go to diff View file
M plugins/crosstracker/tests/unit/CrossTracker/Tests/Builders/InvalidSearchableCollectorParametersBuilder.php +2 −0 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/EqualComparisonVisitor.php +2 −4 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/File/FileFieldChecker.php +69 −21 Go to diff View file
D plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/File/FileToStringComparisonException.php +0 −37 Go to diff View file
D plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/File/ValueForFileExtractor.php +0 −75 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/FlatInvalidFieldChecker.php +7 −5 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/NotEqualComparisonVisitor.php +2 −4 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/Text/TextFieldChecker.php +13 −21 Go to diff View file
M plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidTermCollectorVisitor.php +2 −0 Go to diff View file
M plugins/tracker/site-content/fr_FR/LC_MESSAGES/tuleap-tracker.po +0 −4 Go to diff View file
M plugins/tracker/site-content/pt_BR/LC_MESSAGES/tuleap-tracker.po +0 −4 Go to diff View file
M plugins/tracker/tests/unit/Builders/TrackerFormElementFileFieldBuilder.php +26 −2 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/InvalidTermCollectorVisitorTest.php +20 −3 Go to diff View file