Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

fix: ErrorModal should be openable several times in a row

Download Browse

part of story #31091 Add the hybrid comment to manage comments Why this fix? Before this patch, if the modal opened several times in a row, it ended up "stucked" open. Moreover, the [Show details] state was not reinitialised. How to test: - Put a RestException in PullRequestsResource line 1143 - Submit a global comment --> The modal opens - Click show details - Click [OK] --> The dropdown is closed - Submit a global comment --> The modal opens --> The details are not shown Change-Id: Id6e3d1b393f98757fc01f59bb855b26316f11b6d

+21 −5
Thomas Gorka (tgorka) 2023-03-10 16:11
Thomas Gorka (tgorka) 2023-03-10 16:20
4092bae1cf71459d323d580cd4bec924b529dea6
65d156552eeab18fe7278eb55dd8e5fa270b1439
git #tuleap/stable/4092bae1cf71459d323d580cd4bec924b529dea6

Modified Files

Side by side diff
Inline diff
Name
M plugins/pullrequest/scripts/pullrequest-overview/src/components/Modals/PullRequestErrorModal.test.ts +13 −3 Go to diff View file
M plugins/pullrequest/scripts/pullrequest-overview/src/components/Modals/PullRequestErrorModal.vue +8 −2 Go to diff View file