Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Fix failing tests on PermissionCheckerTest

Download Browse

When you run the tests for the whole Tracker_Permission_PermissionCheckerTest, everything is awesome 🎵 However one specific test in it does not pass if you run it independantly: \Tracker_Permission_PermissionCheckerTest::testTrackerInNotActiveProjectIsOnlyReadableBySuperAdmin() It is due to the static caching in plugins/tracker/include/Tracker/Tracker.class.php:2079. Since the cache is shared between instances, in tests we can have trackers with same id, leading to weird behavior sometimes. 😿 Introduced by git #stable/tuleap/c08d386d6c4f75825d808ad83ff4f5c16a0ef89e Part of request #18330: Promotion of a tracker in +New dropdown is a project admin action Change-Id: I0ec62e86e3ea8bff1d7e316127f706a30df57c35

+1 −0
Nicolas Terray (nterray) 2020-11-25 17:04
Nicolas Terray (nterray) 2020-11-25 17:38
40cebca7e04332421c601313f4226779bbbd2162
87126df4e882d545dd127cd0f281130c167291ad
git #tuleap/stable/40cebca7e04332421c601313f4226779bbbd2162

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/tests/unit/Tracker/Permission/PermissionCheckerTest.php +1 −0 Go to diff View file