Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Refactoring: DRY in Bind->getCriteria{From,Where}

Download Browse

This is part of request #10534: Wrong behavior when we search None in MSB Move common code in the parent abstract class in order to avoid duplication. The only difference is the management of ids to search with a weird array_intersect combination for users/ugroups and a simple array_values for static. Change-Id: I9a210e26c44d7d3734fb93011b558cbfba5da490

+68 −180
Nicolas Terray (nterray) 2017-08-08 11:44
Nicolas Terray (nterray) 2017-08-08 16:43
41a8b1665284d3db5c1562379e0657c56a0938f9
97cca06986c4807fff1af0182ef13332332cb222
git #tuleap/stable/41a8b1665284d3db5c1562379e0657c56a0938f9

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind.class.php +53 −2 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind_Static.class.php +3 −53 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind_Ugroups.class.php +0 −59 Go to diff View file
M plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_List_Bind_Users.class.php +0 −60 Go to diff View file
M plugins/tracker/tests/Tracker/SOAPServerTest.php +12 −6 Go to diff View file