stable
Clone or download
part of story #31091 Add the hybrid comment to manage comments At the very beginning, the idea was to fix the case for the attribute relativeDateHelper of the <tuleap-pullrequest-comment/> component, but it turned out that it was breaking its usage in the angular app. When I realized that the angular app used the same object (with type definition comming from @tuleap/plugin-pullrequest-comments) to display both its relative dates, and the component's relative dates, I've decided to stop requiring a relative date helper in the component, and build it in its controller instead. As a reminder, we had initially implemented a RelativeDateHelper in order to ease the initialisation of <tlp-relative-date/> inside the angular app's templates. Now: - The overview app has its own PullRequestRelativeDate vue component. - The angular app has its own relative dates helper. - The comment component has its own too. -- No functional change expected -- Change-Id: I9a90a07d3d6d803d20ad80043632f6b83970d773
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/package.json | +4 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/pnpm-lock.yaml | +8 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/PullRequestComment.test.ts | +4 | −4 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/PullRequestComment.ts | +4 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/PullRequestCommentBodyTemplate.test.ts | +3 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/PullRequestCommentBodyTemplate.ts | +5 | −5 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/PullRequestCommentController.ts | +9 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/src/comment/PullRequestCurrentUserPresenter.ts | +5 | −0 | Go to diff View file |
| R | plugins/pullrequest/scripts/pullrequest-overview/src/helpers/relative-dates-helper.ts | Go to diff View file | ||
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/src/types.ts | +0 | −7 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/tests/stubs/CurrentPullRequestUserPresenterStub.ts | +5 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/tests/stubs/PullRequestCommentControllerStub.ts | +2 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/tests/stubs/RelativeDateHelperStub.ts | +1 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/lib/pullrequest-comments/tests/stubs/ReplyCommentFormPresenterStub.ts | +3 | −5 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/OverviewThreads.test.ts | +0 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequest-overview/src/components/Threads/OverviewThreads.vue | +7 | −9 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCurrentUserPresenterBuilder.test.ts | +17 | −2 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCurrentUserPresenterBuilder.ts | +11 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-diff-component.js | +4 | −7 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/unidiff-component.js | +4 | −7 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/types.ts | +0 | −6 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/widgets/SideBySideCodeMirrorWidgetCreator.test.ts | +3 | −6 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/widgets/SideBySideCodeMirrorWidgetCreator.ts | +1 | −6 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/helpers/date-helpers.ts | +7 | −1 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/overview/timeline/timeline-controller.js | +7 | −15 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/src/app/overview/timeline/timeline.tpl.html | +0 | −3 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/CurrentPullRequestUserPresenterStub.ts | +3 | −0 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/FileDiffWidgetStub.ts | +1 | −6 | Go to diff View file |
| D | plugins/pullrequest/scripts/pullrequests-app/tests/stubs/RelativeDateHelperStub.ts | +0 | −25 | Go to diff View file |
| M | plugins/pullrequest/scripts/pullrequests-app/tsconfig.json | +3 | −0 | Go to diff View file |