Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Separate tests for repository integration

Download Browse

part of story #26799 associate a Tuleap project and a GitLab group No functional change. Notes: Interface names should not have "Dao" in them, at least not if we want to separate business logic from Database. I therefore renamed it. This also rewrites the test to have two cases: one where the repositories of a group are already integrated, and another where they are not. Having the stub change in each case makes the control flow clearer than having a stub that sometimes returns true or false. Change-Id: Ic759862776e8cc50d3d0913f4e68d2afe3b8355d

+90 −50
Joris MASSON (jmasson) 2022-09-07 17:06
Joris MASSON (jmasson) 2022-09-07 18:58
43db4bf308e10b59d3af25705e452d88dd460a4a
247760ee29a582981855b3c49b5cc25a9d171075
git #tuleap/stable/43db4bf308e10b59d3af25705e452d88dd460a4a

Modified Files

Side by side diff
Inline diff
Name
M plugins/gitlab/include/Repository/GitlabRepositoryGroupLinkHandler.php +2 −2 Go to diff View file
M plugins/gitlab/include/Repository/GitlabRepositoryIntegrationDao.php +1 −1 Go to diff View file
R plugins/gitlab/include/Repository/GitlabRepositoryAlreadyIntegratedDao.php Go to diff View file
M plugins/gitlab/tests/unit/Group/GitlabRepositoryGroupLinkHandlerTest.php +71 −29 Go to diff View file
M plugins/gitlab/tests/unit/Test/Stubs/CreateGitlabRepositoriesStub.php +16 −18 Go to diff View file
R plugins/gitlab/tests/unit/Test/Stubs/GitlabRepositoryAlreadyIntegratedDaoStub.php Go to diff View file