stable
Clone or download
Until now there was two different events to collect the list of pane for a milestone. One for the REST route (to expose "additional_panes") and another one for tabs + breadcrumb dropdown. A precedent work had been done to ensure a suitable taskboard tab position[0] for one of the event. However the other event didn't need to be updated. Since the introduction of "Tests" icon in pv2, it is not anymore the case and we need to have the same order everywhere. The event for the REST route is therefore terminated so that we have the order logic in one place only. In order to save resources and rainforest, the building of active pane (that is irrelevant in REST context) is deferred through a closure. [0] git #tuleap/stable/ef8e58bb223378df760b72800d1b1a4f90c991fc Part of story #14881: Transform “Test Management” pane in “Integrated pane” Test Change-Id: I8066687ab06eba365a36ccb737ab1f73d84666d6
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/agiledashboard/include/AgileDashboard/Milestone/MilestoneRepresentationBuilder.class.php | +11 | −1 | Go to diff View file |
| A | plugins/agiledashboard/include/AgileDashboard/Milestone/Pane/ActivePaneContext.php | +69 | −0 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/Milestone/Pane/PaneInfoCollector.php | +20 | −34 | Go to diff View file |
| D | plugins/agiledashboard/include/AgileDashboard/REST/v1/AdditionalPanesForMilestoneEvent.php | +0 | −60 | Go to diff View file |
| M | plugins/agiledashboard/include/AgileDashboard/REST/v1/MilestoneRepresentation.class.php | +9 | −6 | Go to diff View file |
| M | plugins/agiledashboard/include/Planning/MilestonePaneFactory.class.php | +5 | −3 | Go to diff View file |
| M | plugins/agiledashboard/tests/unit/AgileDashboard/Milestone/Pane/PaneInfoCollectorTest.php | +58 | −3 | Go to diff View file |
| M | plugins/cardwall/include/cardwallPlugin.php | +11 | −8 | Go to diff View file |
| M | plugins/taskboard/include/taskboardPlugin.php | +6 | −22 | Go to diff View file |
| M | plugins/testmanagement/include/testmanagementPlugin.php | +0 | −25 | Go to diff View file |