stable
Clone or download
Part of story #36833 search on semantics and always there fields even if not defined No functional change. CI should be happy. Why ? Now that all the validation rules are grouped by semantic / type of field, the goal is to remove another level of indirection. MetadataChecker now receives InvalidMetadataChecker in its constructor, and uses it directly. There is no longer any checker object in InvalidSearchableCollectorParameters, it only contains the comparison and InvalidComparisonCollectorParameters. Also dropped the "Flat" prefixes from the InvalidMetadataChecker and InvalidFieldChecker classes. The prefix only made sense relative to the previous "<Operator>ComparisonChecker" classes. Change-Id: I261aa319c06f11a26b6a7f8f74f33366a12e3c65
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/crosstracker/include/CrossTracker/REST/v1/CrossTrackerReportsResource.php | +12 | −12 | Go to diff View file |
| M | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/InvalidSearchableCollectorParameters.php | +2 | −19 | Go to diff View file |
| M | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/InvalidSearchableCollectorVisitor.php | +15 | −8 | Go to diff View file |
| M | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/InvalidTermCollectorVisitor.php | +0 | −3 | Go to diff View file |
| D | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Comparison/CheckComparison.php | +0 | −35 | Go to diff View file |
| M | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/DuckTypedField/DuckTypedFieldChecker.php | +5 | −6 | Go to diff View file |
| R | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Metadata/FlatInvalidMetadataChecker.php | Go to diff View file | ||
| M | plugins/crosstracker/include/CrossTracker/Report/Query/Advanced/QueryValidation/Metadata/MetadataChecker.php | +6 | −6 | Go to diff View file |
| M | plugins/crosstracker/include/crosstrackerPlugin.php | +12 | −12 | Go to diff View file |
| M | plugins/crosstracker/tests/integration/CrossTracker/Tests/Report/ArtifactReportFactoryInstantiator.php | +12 | −12 | Go to diff View file |
| M | plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/InvalidTermCollectorVisitorTest.php | +13 | −11 | Go to diff View file |
| M | plugins/crosstracker/tests/unit/CrossTracker/Report/Query/Advanced/QueryValidation/DuckTypedField/DuckTypedFieldCheckerTest.php | +2 | −2 | Go to diff View file |
| M | plugins/crosstracker/tests/unit/CrossTracker/Tests/Builders/InvalidSearchableCollectorParametersBuilder.php | +0 | −16 | Go to diff View file |
| R | plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidFields/FlatInvalidFieldChecker.php | Go to diff View file | ||
| M | plugins/tracker/include/Tracker/Report/Query/Advanced/InvalidSearchableCollectorVisitor.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/Tracker_Report.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Report/Query/Advanced/InvalidTermCollectorVisitorTest.php | +2 | −2 | Go to diff View file |