Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Lazybox search field custom element

Download Browse

No functional change expected. Extracting the search field as a custom element allows to group together all behaviour associated with it at a single place, instead of being scattered across many files. It is a starting point to enable refactoring of the selection and dropdown too. part of story #31537 Add tags and make them updatable part of story #28823 [modal] create artifact Change-Id: I9bd727fa1a8f658d2877d4c57d20287edf0db01f

+501 −643
Joris MASSON (jmasson) 2023-04-17 13:25
Joris MASSON (jmasson) 2023-04-18 15:31
4579f8827c020db9023576fd5b54f5c930e0f195
e182bc1e61e82fda67ccd25739ebb4696d58e572
git #tuleap/stable/4579f8827c020db9023576fd5b54f5c930e0f195

Modified Files

Side by side diff
Inline diff
Name
M lib/frontend/lazybox/package.json +3 −2 Go to diff View file
M lib/frontend/lazybox/pnpm-lock.yaml +7 −0 Go to diff View file
A lib/frontend/lazybox/src/SearchInput.test.ts +184 −0 Go to diff View file
A lib/frontend/lazybox/src/SearchInput.ts +131 −0 Go to diff View file
M lib/frontend/lazybox/src/dropdown/DropdownManager.test.ts +29 −3 Go to diff View file
M lib/frontend/lazybox/src/dropdown/DropdownManager.ts +7 −2 Go to diff View file
M lib/frontend/lazybox/src/events/EventManager.test.ts +29 −137 Go to diff View file
M lib/frontend/lazybox/src/events/EventManager.ts +6 −93 Go to diff View file
D lib/frontend/lazybox/src/events/SearchFieldClearer.test.ts +0 −37 Go to diff View file
D lib/frontend/lazybox/src/events/SearchFieldClearer.ts +0 −29 Go to diff View file
D lib/frontend/lazybox/src/events/SearchFieldEventCallbackHandler.test.ts +0 −75 Go to diff View file
D lib/frontend/lazybox/src/events/SearchFieldEventCallbackHandler.ts +0 −50 Go to diff View file
M lib/frontend/lazybox/src/helpers/keys-helper.test.ts +11 −35 Go to diff View file
M lib/frontend/lazybox/src/helpers/keys-helper.ts +0 −4 Go to diff View file
M lib/frontend/lazybox/src/lazybox.ts +12 −19 Go to diff View file
M lib/frontend/lazybox/src/navigation/FieldFocusManager.test.ts +8 −31 Go to diff View file
M lib/frontend/lazybox/src/navigation/FieldFocusManager.ts +2 −7 Go to diff View file
M lib/frontend/lazybox/src/renderers/BaseComponentRenderer.test.ts +2 −2 Go to diff View file
M lib/frontend/lazybox/src/renderers/BaseComponentRenderer.ts +15 −19 Go to diff View file
M lib/frontend/lazybox/src/renderers/__snapshots__/DropdownContentRenderer.test.ts.snap +1 −1 Go to diff View file
M lib/frontend/lazybox/src/selection/MultipleSelectionManager.test.ts +24 −28 Go to diff View file
M lib/frontend/lazybox/src/selection/MultipleSelectionManager.ts +10 −17 Go to diff View file
M lib/frontend/lazybox/src/selection/SelectionManager.test.ts +12 −5 Go to diff View file
M lib/frontend/lazybox/src/selection/SelectionManager.ts +3 −3 Go to diff View file
M lib/frontend/lazybox/src/type.ts +2 −1 Go to diff View file
D lib/frontend/lazybox/tests/stubs/ClearSearchFieldStub.ts +0 −34 Go to diff View file
M lib/frontend/lazybox/themes/style.scss +1 −8 Go to diff View file
M lib/frontend/lazybox/vite.config.ts +2 −1 Go to diff View file