stable
Clone or download
Read-only
request #14936: The zip archive of a document folder should not be indicated as public information
As the zip archive of a folder takes into account the permissions it cannot be put in a public cache without potentially leaking restricted documents. In order to fix the issue and to have a consistent behavior when downloading large files from a Tuleap instance (without duplication code), the controller has been transformed into something that can support PSR-15 middleware and PSR-7 interfaces. Change-Id: I6dd607c9624763a4c7e0276a1e14a87e6359b29b
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/document/include/DownloadFolderAsZip/DocumentFolderZipStreamer.php | +65 | −39 | Go to diff View file |
| M | plugins/document/include/documentPlugin.php | +11 | −1 | Go to diff View file |
| M | plugins/document/tests/unit/DownloadFolderAsZip/DocumentFolderZipStreamerTest.php | +11 | −6 | Go to diff View file |
| M | src/common/Http/Response/BinaryFileResponseBuilder.php | +23 | −4 | Go to diff View file |
| A | src/common/Http/Response/Stream/CallbackNoBufferStream.php | +142 | −0 | Go to diff View file |
| M | tests/unit/common/Http/Response/BinaryFileResponseBuilderTest.php | +28 | −7 | Go to diff View file |
| A | tests/unit/common/Http/Response/Stream/CallbackNoBufferStreamTest.php | +56 | −0 | Go to diff View file |