stable
Clone or download
Part of request #19306 @mention does not work in HTML format for follow-ups and text fields How to test: - Rebuild tracker and all its dependencies: $ cd tuleap; npx lerna --concurrency=1 exec --stream \ --scope=@tuleap/plugin-tracker --include-dependencies "npm run build" @username auto-completion works as before in the combination of those situations: - HTML format - Text / Markdown format - in the Text fields in the Artifact view - when adding a new Follow-up comment in the Artifact edition view - when editing an existing follow-up comment in the Artifact edition view - in the Text fields in the Modal v2 Notes: - The atwho lib is removed from the tuleap-combined blob of concatenated JS. It should not have been called elsewhere than the modified files (tuleap.mention.init call) - For lack of a more precise stylesheet, the atwho CSS is added to Trackers' stylesheet. It's still better than loading it on every FlamingParrot page ever. - <irony>I am very happy and not at all frustrated to have to add a dependency on an unmaintained vendored minified lib, that is really easy to debug, based on jQuery that we're trying to drop, to a shiny new TypeScript code.</irony> Change-Id: I69bef6a1b72d041438eaab43c31b226a603acedf
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | .gitignore | +1 | −1 | Go to diff View file |
| M | plugins/tracker/package.json | +1 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/artifact/create-view.ts | +1 | −1 | Go to diff View file |
| M | plugins/tracker/scripts/artifact/edition/edit-follow-up-comment.js | +4 | −4 | Go to diff View file |
| M | plugins/tracker/scripts/lib/rich-text-editor/README.md | +7 | −5 | Go to diff View file |
| M | plugins/tracker/scripts/lib/rich-text-editor/package.json | +1 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/lib/rich-text-editor/src/TextEditor.test.ts | +84 | −73 | Go to diff View file |
| M | plugins/tracker/scripts/lib/rich-text-editor/src/TextEditor.ts | +8 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/lib/rich-text-editor/webpack.common.js | +1 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/modal-v2/modal-in-place.js | +5 | −2 | Go to diff View file |
| M | plugins/tracker/themes/FlamingParrot/css/style.scss | +1 | −0 | Go to diff View file |
| M | plugins/tracker/webpack.common.js | +1 | −1 | Go to diff View file |
| M | src/common/layout/Layout.class.php | +0 | −1 | Go to diff View file |
| M | src/package.json | +1 | −0 | Go to diff View file |
| M | src/scripts/codendi/RichTextEditor.js | +2 | −1 | Go to diff View file |
| A | src/scripts/lib/mention/.gitignore | +1 | −0 | Go to diff View file |
| A | src/scripts/lib/mention/README.md | +36 | −0 | Go to diff View file |
| A | src/scripts/lib/mention/package-lock.json | +7 | −0 | Go to diff View file |
| A | src/scripts/lib/mention/package.json | +33 | −0 | Go to diff View file |
| A | src/scripts/lib/mention/src/mention.d.ts | +20 | −0 | Go to diff View file |
| A | src/scripts/lib/mention/src/mention.js | +67 | −0 | Go to diff View file |
| R | src/www/scripts/vendor/at/css/atwho.min.css | Go to diff View file | ||
| R | src/www/scripts/vendor/at/js/atwho.min.js | Go to diff View file | ||
| R | src/www/scripts/vendor/at/js/caret.min.js | Go to diff View file | ||
| A | src/scripts/lib/mention/vite.config.ts | +39 | −0 | Go to diff View file |
| M | src/webpack.common.js | +1 | −3 | Go to diff View file |
| D | src/www/scripts/tuleap/tuleap-mention.js | +0 | −67 | Go to diff View file |
| M | src/www/themes/FlamingParrot/FlamingParrot_Theme.class.php | +0 | −1 | Go to diff View file |