Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Switch eslint to vue 3 and load styles through Vite assets

Download Browse

part of story #38263 Choose my own columns based on field name (numeric, text, dates) How to test: No functional change expected in cross-tracker widgets. Styles are still loaded and the widgets function as before. Why? We had forgotten to add the widget to the eslint list of vue 3 apps, so the vue 2 rules still applied. We can now remove superfluous <divs> that only existed to have a unique root node in Vue 2 components. Note that those rules require prop casing to be snake_case, so all prop names are changed accordingly. The styles can also be loaded by side-effect of the JS assets (ViteAssets handle that). This will enable us to write the styles close to the components in <style> tags. Change-Id: Ifb65f4bd7de2349bcc6241bc5b76ca4072d83c93

+183 −194
Joris MASSON (jmasson) 2024-06-27 16:15
Joris MASSON (jmasson) 2024-06-27 16:54
46cf1016db513a626df246e8033bb46015132220
9f032d78c3eaf5a050d809288fbc0d92c0260779
git #tuleap/stable/46cf1016db513a626df246e8033bb46015132220

Modified Files

Side by side diff
Inline diff
Name
M .eslintrc.js +1 −1 Go to diff View file
M plugins/crosstracker/build-manifest.json +1 −1 Go to diff View file
M plugins/crosstracker/include/CrossTracker/Widget/ProjectCrossTrackerSearch.php +0 −12 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/package.json +1 −0 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/pnpm-lock.yaml +3 −0 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/CrossTrackerWidget.test.ts +25 −25 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/CrossTrackerWidget.vue +37 −37 Go to diff View file
R plugins/crosstracker/scripts/cross-tracker/src/components/ArtifactTable.test.ts Go to diff View file
R plugins/crosstracker/scripts/cross-tracker/src/components/ArtifactTable.vue Go to diff View file
R plugins/crosstracker/scripts/cross-tracker/src/components/ArtifactTableRow.vue Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/index.ts +4 −3 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/reading-mode/ReadingMode.test.ts +11 −11 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/reading-mode/ReadingMode.vue +49 −51 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/reading-mode/TrackerListReadingMode.vue +3 −3 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/QueryEditor.test.ts +10 −10 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/QueryEditor.vue +4 −4 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/TrackerSelection.test.ts +2 −2 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/TrackerSelection.vue +2 −2 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/WritingMode.test.ts +23 −23 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/src/writing-mode/WritingMode.vue +6 −6 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/themes/cross-tracker.scss +1 −2 Go to diff View file
M plugins/crosstracker/scripts/cross-tracker/vite.config.ts +0 −1 Go to diff View file