stable
Clone or download
Read-only
I'm sorry in advance for the lengthy review; I started by renaming stuff in Type creation/edition and ended up renaming mostly everything in tracker and few plugins. No functional changes is expected. Non exhaustive list of impacted features: * CRUD artifact link types in site admin » tracker * Tracker main administration * Report (add/remove some dedicated artifact link types column) * Artifact view (artifact link field, follow-up comments details) * Children tab of artifact view REST representations have been left as is to not introduce a breaking change. The same for XML export/import. Maybe an approach would be to introduce a new "type" entry alongside "nature" so that we can deprecate the latter. This can be done later. The report's session is also left intact to not force users to be disconnected. It can also be done later if needed. Part of story #23042: have "parent" as type within artifacts links Change-Id: I87567a5e3b325f25592ec30cb3601454762ad4b8
Modified Files
| Name | ||||
|---|---|---|---|---|
| M | plugins/artifactsfolders/bin/convert_from_folders_to_scrum.php | +2 | −2 | Go to diff View file |
| M | plugins/artifactsfolders/include/Converter/AncestorFolderChecker.php | +3 | −3 | Go to diff View file |
| M | plugins/artifactsfolders/include/Converter/ConverterDao.php | +2 | −2 | Go to diff View file |
| M | plugins/artifactsfolders/include/Folder/ArtifactPresenterBuilder.php | +8 | −8 | Go to diff View file |
| M | plugins/artifactsfolders/include/Folder/Dao.php | +2 | −2 | Go to diff View file |
| M | plugins/artifactsfolders/include/Folder/DataFromRequestAugmentor.php | +2 | −2 | Go to diff View file |
| M | plugins/artifactsfolders/include/Folder/HierarchyOfFolderBuilder.php | +3 | −3 | Go to diff View file |
| M | plugins/artifactsfolders/include/Folder/PostSaveNewChangesetCommand.php | +2 | −2 | Go to diff View file |
| R | plugins/artifactsfolders/include/Nature/TypeInFolderPresenter.php | Go to diff View file | ||
| M | plugins/artifactsfolders/include/artifactsfoldersPlugin.php | +23 | −23 | Go to diff View file |
| M | plugins/document_generation/include/document_generationPlugin.php | +2 | −2 | Go to diff View file |
| M | plugins/frs/include/FRS/REST/v1/ReleaseRepresentation.php | +2 | −2 | Go to diff View file |
| M | plugins/jira_import/include/Project/ArtifactLinkType/ArtifactLinkTypeImporter.php | +5 | −5 | Go to diff View file |
| M | plugins/jira_import/include/jira_importPlugin.php | +6 | −6 | Go to diff View file |
| M | plugins/jira_import/tests/unit/Project/ArtifactLinkType/ArtifactLinkTypeImporterTest.php | +4 | −4 | Go to diff View file |
| M | plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/IterationCreationProcessorBuilder.php | +2 | −2 | Go to diff View file |
| M | plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/IterationUpdateProcessorBuilder.php | +2 | −2 | Go to diff View file |
| M | plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/ProgramIncrementUpdateProcessorBuilder.php | +2 | −2 | Go to diff View file |
| M | plugins/program_management/include/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/ArtifactLinkValueFormatter.php | +3 | −3 | Go to diff View file |
| M | plugins/program_management/include/Domain/Program/Backlog/ProgramIncrement/Source/Changeset/Values/ArtifactLinkType.php | +1 | −1 | Go to diff View file |
| M | plugins/program_management/tests/e2e/cypress/cypress/integration/program_management.spec.ts | +1 | −1 | Go to diff View file |
| M | plugins/program_management/tests/rest/v1/Helper/ProgramDataBuilder.php | +4 | −5 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/AsynchronousCreation/ArtifactCreatorAdapterTest.php | +1 | −1 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/AsynchronousCreation/ChangesetAdderTest.php | +2 | −2 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/ArtifactLinkValueFormatterTest.php | +5 | −5 | Go to diff View file |
| M | plugins/program_management/tests/unit/Adapter/Program/Backlog/ProgramIncrement/Source/Changeset/Values/ChangesetValuesFormatterTest.php | +2 | −2 | Go to diff View file |
| M | plugins/roadmap/include/Roadmap/REST/v1/RoadmapResource.php | +2 | −2 | Go to diff View file |
| M | plugins/roadmap/include/Roadmap/REST/v1/TasksResource.php | +2 | −2 | Go to diff View file |
| M | plugins/roadmap/include/roadmapPlugin.php | +2 | −2 | Go to diff View file |
| M | plugins/roadmap/tests/unit/Roadmap/Widget/RoadmapWidgetPresenterBuilderTest.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/include/REST/Artifact/ArtifactRepresentationBuilder.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/include/REST/v1/ArtifactLinkRepresentation.php | +25 | −25 | Go to diff View file |
| M | plugins/tracker/include/REST/v1/ArtifactsResource.class.php | +7 | −7 | Go to diff View file |
| M | plugins/tracker/include/REST/v1/ReportsResource.class.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/include/REST/v1/TrackersResource.class.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Action/CreateArtifact.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Action/UpdateArtifact.class.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/Artifact.php | +10 | −10 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/ArtifactChildPresenter.class.php | +4 | −4 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/ArtifactsDeletion/ArchiveAndDeleteArtifactTaskBuilder.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/Changeset/InitialChanagesetFieldsValidator.class.php | +1 | −1 | Go to diff View file |
| R | plugins/tracker/include/Tracker/Artifact/ChangesetValue/ArtifactLink/AddedLinkByNatureCollection.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/Artifact/ChangesetValue/ArtifactLink/UpdatedNatureLinkCollection.php | Go to diff View file | ||
| M | plugins/tracker/include/Tracker/Artifact/Renderer/CopyRenderer.class.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/Renderer/EditRenderer.class.php | +6 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/Tracker_ArtifactLinkInfo.class.php | +11 | −11 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/Tracker_Artifact_ChangesetValue_ArtifactLink.class.php | +6 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/Tracker_Artifact_ChangesetValue_ArtifactLinkDiff.class.php | +42 | −42 | Go to diff View file |
| R | plugins/tracker/include/Tracker/Artifact/View/Nature.php | Go to diff View file | ||
| M | plugins/tracker/include/Tracker/Artifact/XMLImport.class.php | +6 | −6 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/XMLImport/ArtifactFieldsDataBuilder.class.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/XMLImport/XMLImportFieldStrategyArtifactLink.class.php | +37 | −52 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Artifact/XMLImportBuilder.class.php | +4 | −4 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Config/ArtifactLinkTypePresenter.php | +1 | −4 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Config/ArtifactsDeletionPresenter.php | +1 | −4 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Config/ConfigController.php | +17 | −17 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Config/EmailGateWayPresenter.php | +1 | −4 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Config/ReportPresenter.php | +1 | −4 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Config/SectionsPresenter.php | +14 | −27 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/ArtifactLinkValidator.php | +16 | −16 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/ArtifactLinkFieldValueDao.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/ArtifactLinkUpdaterDataFormater.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/ArtifactLinkValueSaver.php | +27 | −27 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/ArtifactLinksToRender.php | +45 | −45 | Go to diff View file |
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/ArtifactLinksToRenderForPerNatureTable.php | Go to diff View file | ||
| M | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/FieldDataBuilder.php | +10 | −10 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/RequestDataAugmentor.php | +14 | −14 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/SubmittedValueConvertor.php | +15 | −15 | Go to diff View file |
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/ArtifactInNatureTablePresenter.php | Go to diff View file | ||
| M | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/CustomColumn/ValueFormatter.php | +5 | −2 | Go to diff View file |
| D | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/InvalidNatureParameterException.php | +0 | −26 | Go to diff View file |
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/UnableToEditNatureException.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/NatureConfigController.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/NatureConfigPresenter.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/NatureCreator.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/NatureCreatorInterface.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/NatureDao.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/NatureDeletor.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/NatureEditor.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/NatureIsChildLinkRetriever.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/NatureManagementException.php | Go to diff View file | ||
| M | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/TypePresenterFactory.php | +8 | −8 | Go to diff View file |
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/NatureSelectorPresenter.php | Go to diff View file | ||
| M | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/TypeSelectorRenderer.php | +8 | −8 | Go to diff View file |
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/NatureTablePresenter.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/NatureUsagePresenter.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/NatureUsagePresenterFactory.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/NatureValidator.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/UnableToCreateNatureException.php | Go to diff View file | ||
| R | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/UnableToDeleteNatureException.php | Go to diff View file | ||
| A | plugins/tracker/include/Tracker/FormElement/Field/ArtifactLink/Type/UnableToEditTypeException.php | +26 | −0 | Go to diff View file |
| M | plugins/tracker/include/Tracker/FormElement/Tracker_FormElement_Field_ArtifactLink.php | +78 | −78 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Hierarchy/HierarchyDAO.php | +13 | −13 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Hierarchy/HierarchyFactory.class.php | +5 | −5 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/Tracker_Report.class.php | +12 | −12 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/Tracker_Report_Renderer_Table.class.php | +89 | −89 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Report/dao/Tracker_Report_Renderer_Table_ColumnsDao.class.php | +7 | −7 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Semantic/Progress/MethodBasedOnLinksCount.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Semantic/Progress/MethodBuilder.php | +5 | −21 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Semantic/Progress/SemanticProgress.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Semantic/Tracker_SemanticManager.class.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/include/Tracker/Tracker.class.php | +14 | −14 | Go to diff View file |
| M | plugins/tracker/include/Tracker/XML/Exporter/ChangesetValue/ChangesetValueArtifactLinkXMLExporter.class.php | +1 | −1 | Go to diff View file |
| M | plugins/tracker/include/TrackerXmlExport.class.php | +4 | −4 | Go to diff View file |
| M | plugins/tracker/include/trackerPlugin.php | +23 | −23 | Go to diff View file |
| D | plugins/tracker/scripts/admin-nature.js | +0 | −62 | Go to diff View file |
| A | plugins/tracker/scripts/admin-type.js | +62 | −0 | Go to diff View file |
| M | plugins/tracker/scripts/legacy/LoadTrackerArtifactLink.js | +1 | −1 | Go to diff View file |
| M | plugins/tracker/scripts/legacy/TrackerArtifactLink.js | +21 | −21 | Go to diff View file |
| M | plugins/tracker/scripts/legacy/TrackerReports.js | +6 | −6 | Go to diff View file |
| M | plugins/tracker/scripts/legacy/load-artifactChildren.js | +2 | −2 | Go to diff View file |
| R | plugins/tracker/scripts/legacy/tracker-report-nature-column.js | Go to diff View file | ||
| M | plugins/tracker/site-content/en_US/script_locale.txt | +2 | −2 | Go to diff View file |
| M | plugins/tracker/site-content/fr_FR/script_locale.txt | +2 | −2 | Go to diff View file |
| R | plugins/tracker/templates/artifactlink-nature-selector.mustache | Go to diff View file | ||
| R | plugins/tracker/templates/artifactlink-nature-table-head.mustache | Go to diff View file | ||
| R | plugins/tracker/templates/artifactlink-nature-table-row.mustache | Go to diff View file | ||
| R | plugins/tracker/templates/artifactlink-nature-table.mustache | Go to diff View file | ||
| M | plugins/tracker/templates/global-admin/artifact-links.mustache | +1 | −1 | Go to diff View file |
| M | plugins/tracker/templates/siteadmin-config/site-admin-navbar.mustache | +1 | −1 | Go to diff View file |
| R | plugins/tracker/templates/siteadmin-config/natures-modal-create.mustache | Go to diff View file | ||
| R | plugins/tracker/templates/siteadmin-config/natures-modal-delete.mustache | Go to diff View file | ||
| R | plugins/tracker/templates/siteadmin-config/natures-modal-edit.mustache | Go to diff View file | ||
| R | plugins/tracker/templates/siteadmin-config/natures.mustache | Go to diff View file | ||
| M | plugins/tracker/tests/e2e/cypress/cypress/integration/artifact_link-usage.spec.ts | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/Tracker_Artifact_XMLImportTest.php | +4 | −4 | Go to diff View file |
| M | plugins/tracker/tests/unit/Artifact/XMLImport/TrackerArtifactXMLImportArtifactFieldsDataBuilderTest.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/tests/unit/REST/Artifact/ArtifactRepresentationBuilderTest.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Action/Tracker_Action_UpdateArtifactTest.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Artifact/ChangesetValue/ArtifactLinkDiffTest.php | +8 | −8 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Artifact/XMLImport/XMLImportFieldStrategyArtifactLinkTest.php | +11 | −11 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Artifact/XmlImportTest.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/FormElement/ArtifactLinkValidatorTest.php | +60 | −60 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/ArtifactLinkUpdaterDataFormaterTest.php | +10 | −10 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/GetFieldDataTest.php | +12 | −12 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/RequestDataAugmentorTest.php | +27 | −27 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/SubmittedValueConvertorTest.php | +18 | −18 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/Type/NatureValidatorTest.php | +9 | −9 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/FormElement/Field/ArtifactLink/Type/TypePresenterFactoryTest.php | +5 | −5 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/FormElement/Tracker_FormElement_Field_ArtifactLinkTest.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Hierarchy/HierarchyFactoryTest.php | +4 | −4 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Hierarchy/TrackerHierarchyFactoryGetParentArtifactTest.php | +3 | −3 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Hierarchy/TrackerHierarchyFactoryGetParentTest.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/Semantic/Progress/MethodBasedOnLinksCountTest.php | +2 | −2 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/XML/Exporter/ChangesetValue/Tracker_XML_Exporter_ChangesetValue_ChangesetValueArtifactLinkXMLExporterTest.php | +14 | −14 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker/XML/Exporter/TrackerXmlExportTest.php | +7 | −7 | Go to diff View file |
| M | plugins/tracker/tests/unit/Tracker_Artifact_ChangesetValue_ArtifactLinkTest.php | +6 | −6 | Go to diff View file |
| M | plugins/tracker/themes/default/css/style.scss | +4 | −4 | Go to diff View file |
| M | plugins/tracker/webpack.common.js | +2 | −2 | Go to diff View file |
| M | tests/psalm/tuleap-baseline.xml | +91 | −102 | Go to diff View file |