stable

Clone or download

Read-only

Mirror milestone also copies description

Part of story #16125 [release management] create a new Aggregator Release How to test: - Set up multi projects - In the Aggregator project, create a new Release and fill its Description field. - Mirror releases should be created in all the Contributor projects. Each mirror release should have the same Description filled with the same content. /!\ Image upload in the description is not supported (it won't be copied). Note to reviewer: this contribution is also mixed with a refactoring to DRY the usage of semantics in multi project backlog. Sorry for the size of the review but I don't have the heart to extract it into its own review yet... The main goal was to stop copy/pasting everywhere the semantic factories getting semantics and checking if they aren't null and getting their fields and checking the fields aren't null. There should be no functional change in the "Mirror milestone creation checks". Change-Id: I7e9b8b8d54ef6673223b25d05fef6acc76606898

Modified Files

Name
M plugins/multi_project_backlog/include/Aggregator/Milestone/CreationCheck/MilestoneCreatorChecker.php +1 −1 Go to diff View file
M plugins/multi_project_backlog/include/Aggregator/Milestone/Mirroring/CopiedValues.php +15 −0 Go to diff View file
M plugins/multi_project_backlog/include/Aggregator/Milestone/Mirroring/CopiedValuesGatherer.php +47 −18 Go to diff View file
M plugins/multi_project_backlog/include/Aggregator/Milestone/Mirroring/MirrorMilestoneFieldsData.php +38 −9 Go to diff View file
M plugins/multi_project_backlog/include/Aggregator/Milestone/Mirroring/MirrorMilestonesCreator.php +11 −10 Go to diff View file
A plugins/multi_project_backlog/include/Aggregator/Milestone/Mirroring/NoDescriptionChangesetValueException.php +31 −0 Go to diff View file
D plugins/multi_project_backlog/include/Aggregator/Milestone/Mirroring/TargetFields.php +0 −61 Go to diff View file
D plugins/multi_project_backlog/include/Aggregator/Milestone/Mirroring/TargetFieldsGatherer.php +0 −82 Go to diff View file
M plugins/multi_project_backlog/include/Aggregator/Milestone/SynchronizedFieldCollectionBuilder.php +9 −108 Go to diff View file
A plugins/multi_project_backlog/include/Aggregator/Milestone/SynchronizedFields.php +122 −0 Go to diff View file
A plugins/multi_project_backlog/include/Aggregator/Milestone/SynchronizedFieldsGatherer.php +146 −0 Go to diff View file
A plugins/multi_project_backlog/include/Aggregator/Milestone/TimeframeFields.php +88 −0 Go to diff View file
M plugins/multi_project_backlog/include/multi_project_backlogPlugin.php +23 −14 Go to diff View file
M plugins/multi_project_backlog/tests/unit/Aggregator/Milestone/Mirroring/ArtifactCreatedHandlerTest.php +11 −9 Go to diff View file
M plugins/multi_project_backlog/tests/unit/Aggregator/Milestone/Mirroring/CopiedValuesGathererTest.php +75 −62 Go to diff View file
M plugins/multi_project_backlog/tests/unit/Aggregator/Milestone/Mirroring/MirrorMilestoneFieldsDataTest.php +66 −24 Go to diff View file
M plugins/multi_project_backlog/tests/unit/Aggregator/Milestone/Mirroring/MirrorMilestonesCreatorTest.php +60 −37 Go to diff View file
D plugins/multi_project_backlog/tests/unit/Aggregator/Milestone/Mirroring/TargetFieldsGathererTest.php +0 −115 Go to diff View file
M plugins/multi_project_backlog/tests/unit/Aggregator/Milestone/SynchronizedFieldCollectionBuilderTest.php +33 −40 Go to diff View file
A plugins/multi_project_backlog/tests/unit/Aggregator/Milestone/SynchronizedFieldsGathererTest.php +252 −0 Go to diff View file
A plugins/multi_project_backlog/tests/unit/Aggregator/Milestone/SynchronizedFieldsTest.php +52 −0 Go to diff View file
A plugins/multi_project_backlog/tests/unit/Aggregator/Milestone/TimeframeFieldsTest.php +50 −0 Go to diff View file
M plugins/projectmilestones/tests/unit/Widget/ProjectMilestonesWidgetRetrieverTest.php +3 −1 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_Artifact_ChangesetValue_Text.class.php +3 −0 Go to diff View file
M plugins/tracker/include/Tracker/Semantic/Timeframe/TimeframeBrokenConfigurationException.php +2 −5 Go to diff View file