Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

feat: Check presence of semantic title during notif

Download Browse

If tracker is not configured to send calendar events, then nothing change. If tracker is configured to send calendar events and has title semantic configured, then in the logs /var/log/tuleap/mail_syslog when the update of an artifact induces a mail notification, we have: > Tracker is configured to send calendar events alongside notification > No calendar event for this changeset (Actual event calendar will come in a dedicated contribution) If tracker is configured to send calendar events but does not have title semantic configured, then in the logs /var/log/tuleap/mail_syslog when the update of an artifact induces a mail notification, we have: > Tracker is configured to send calendar events alongside notification > The tracker does not have title semantic, we cannot build calendar events Implementation note: Not cluttering EmailNotificationTask forces us to declare an unused (yet) MailAttachment. It will be used later when we have minimal background checks before sending the event as attachment. To configure tracker you have to manually update plugin_tracker_calendar_event_config table. Part of story #35094: have "calendar" events attached to tracker email notification Change-Id: I8f092a9df157e47c320b289fd80a6a63b1a524e5

+473 −82
Nicolas Terray (nterray) 2023-11-14 17:29
Nicolas Terray (nterray) 2023-11-15 09:54
4857a4fce6e5078f7a66bc123c60c25a29216564
4c5d49ad2e2cf1bbcfd23b40b8223d90562838be
git #tuleap/stable/4857a4fce6e5078f7a66bc123c60c25a29216564

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/ActionsRunner.php +3 −1 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/EmailNotificationAttachmentProvider.php +53 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/EmailNotificationTask.php +38 −68 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/MailSender.php +3 −1 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/ProvideEmailNotificationAttachment.php +33 −0 Go to diff View file
M plugins/tracker/include/Tracker/Notifications/Settings/CalendarEventConfigDao.php +14 −1 Go to diff View file
A plugins/tracker/include/Tracker/Notifications/Settings/CheckEventShouldBeSentInNotification.php +26 −0 Go to diff View file
A plugins/tracker/tests/integration/Tracker/Notifications/Settings/CalendarEventConfigDaoTest.php +63 −0 Go to diff View file
A plugins/tracker/tests/unit/Stub/Tracker/Artifact/Changeset/PostCreation/ProvideEmailNotificationAttachmentStub.php +51 −0 Go to diff View file
A plugins/tracker/tests/unit/Stub/Tracker/Notifications/Settings/CheckEventShouldBeSentInNotificationStub.php +47 −0 Go to diff View file
A plugins/tracker/tests/unit/Tracker/Artifact/Changeset/PostCreation/EmailNotificationAttachmentProviderTest.php +83 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Artifact/Changeset/PostCreation/EmailNotificationTaskTest.php +21 −9 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Artifact/Changeset/PostCreation/NotifierCustomSenderTest.php +5 −2 Go to diff View file
A src/common/Mail/MailAttachment.php +33 −0 Go to diff View file