Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Show confirm modal

Download Browse

part of: story #12404 download folder as zip A confirmation modal is needed to tell the user what will be contained in the archive. It also warns about the existence of TULEAP_ERRORS.txt when a file could not have been added to the archive. This warning has also been added to the warning modal since the download is not prevented. I took the opportunity to do a micro-refactoring of the way we trigger the download. Now, we don't set window.location with the href of the archive anymore, we define confirm buttons as links whose hrefs point to it. How to test: - Pick up a light folder, click on [Download as a zip] --> The confirm modal opens - Click cancel --> It closes the modal - Click Download --> The download starts - Same behavior with the warning modal Change-Id: I092d19ec732021b509cba6c4fac23b884e4a87e9

+264 −26
Thomas Gorka (tgorka) 2020-05-18 17:51
Thomas Gorka (tgorka) 2020-05-19 11:34
48fc875a9dec7eb0535772298cb1daac354f79e3
a6528a02a706cf9d4d40bd2ecd1d604c72ca96ca
git #tuleap/stable/48fc875a9dec7eb0535772298cb1daac354f79e3

Modified Files

Side by side diff
Inline diff
Name
M plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/DownloadFolderAsZip.test.js +8 −9 Go to diff View file
M plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/DownloadFolderAsZip.vue +5 −1 Go to diff View file
M plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/ModalArchiveSizeWarning.test.js +6 −9 Go to diff View file
M plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/ModalArchiveSizeWarning.vue +8 −7 Go to diff View file
A plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/ModalConfirmArchiveDownload.test.js +63 −0 Go to diff View file
A plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/ModalConfirmArchiveDownload.vue +100 −0 Go to diff View file
A plugins/document/scripts/document/components/Folder/DropDown/DownloadFolderAsZip/WarningAboutArchiveErrors.vue +10 −0 Go to diff View file
M plugins/document/scripts/document/components/Folder/FolderHeader.test.js +20 −0 Go to diff View file
M plugins/document/scripts/document/components/Folder/FolderHeader.vue +18 −0 Go to diff View file
M plugins/document/scripts/document/po/fr.po +26 −0 Go to diff View file