stable
Clone or download
Read-only
Part of story #13453: finish drag'n drop images in tracker text areas First step to integrating the Image drag'n'drop in the angular modal. To ease reviews, we start by extracting the text field into a separate directive. Next we'll extract the follow-ups editor. How to test: - build the scrum planning app - No functional changes expected. Note to reviewer: There is a bug with HTML format and required text fields [0]. It was already present before and I can't seem to fix it with the current integration library used (ng.ckeditor) so it'll have to wait for the future modal rework in Vue. [0] request #13467 Artifact-modal allows empty required text fields when format is HTML Change-Id: I70ba067819afa700e7e0c0c72dc9cf1f37bac653
Modified Files
Name | ||||
---|---|---|---|---|
M | plugins/tracker/www/scripts/angular-artifact-modal/src/index.spec.js | +1 | −0 | Go to diff View file |
M | plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-controller.js | +33 | −34 | Go to diff View file |
M | plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/date-field/date-field.tpl.html | +7 | −5 | Go to diff View file |
M | plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/fields.js | +22 | −1 | Go to diff View file |
A | plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/text-field/text-field-controller.js | +59 | −0 | Go to diff View file |
A | plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/text-field/text-field-controller.spec.js | +95 | −0 | Go to diff View file |
A | plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/text-field/text-field-directive.js | +37 | −0 | Go to diff View file |
A | plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/text-field/text-field.js | +26 | −0 | Go to diff View file |
A | plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-fields/text-field/text-field.tpl.html | +62 | −0 | Go to diff View file |
M | plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-service.js | +2 | −10 | Go to diff View file |
M | plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal-service.spec.js | +0 | −8 | Go to diff View file |
M | plugins/tracker/www/scripts/angular-artifact-modal/src/tuleap-artifact-modal.tpl.html | +7 | −33 | Go to diff View file |
M | plugins/tracker/www/scripts/constants/fields-constants.js | +5 | −1 | Go to diff View file |