Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: Split ActionsRunner in 2 classes

Download Browse

Part of story #35093 execute custom code as artifact post action A PostAction can have ActionsRunner in its dependencies, in this case we have a cycle dependency because ActionsRunner also need this PostAction. To avoid that, this commit split ActionsRunner in 2 classes : - ActionsQueuer which add the post action in queue (or exec it now if workers are not available) - ActionsRunner which execute actions. *Implementation note:* NewChangesetCreator now uses ActionsQueuer *Testing:* No functional changes expected. PostActions should works as before. Change-Id: Iecaf8e99384a59682a507d2f0def94625a518a5b

+383 −331
Kevin Traini (ktraini) 2024-01-15 11:35
Kevin Traini (ktraini) 2024-01-15 12:04
494598610a47f328be4b0a4800e284650efffc7d
0291cf1fa5e0b5b1a9ea88147ca3eddd30f1c6ef
git #tuleap/stable/494598610a47f328be4b0a4800e284650efffc7d

Modified Files

Side by side diff
Inline diff
Name
M plugins/gitlab/include/gitlabPlugin.php +5 −5 Go to diff View file
M plugins/kanban/include/Kanban/REST/v1/KanbanItemsResource.php +2 −2 Go to diff View file
M plugins/kanban/include/Kanban/REST/v1/KanbanResource.php +2 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/IterationCreationProcessorBuilder.php +2 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/IterationUpdateProcessorBuilder.php +2 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/ProgramIncrementCreationProcessorBuilder.php +2 −2 Go to diff View file
M plugins/program_management/include/Adapter/Program/Backlog/AsynchronousCreation/ProgramIncrementUpdateProcessorBuilder.php +2 −2 Go to diff View file
M plugins/program_management/include/program_managementPlugin.php +2 −2 Go to diff View file
M plugins/taskboard/include/REST/v1/Card/CardPatcher.php +2 −2 Go to diff View file
M plugins/taskboard/include/REST/v1/Cell/CardMappedFieldUpdater.php +2 −2 Go to diff View file
M plugins/testmanagement/include/TestManagement/REST/v1/CampaignsResource.class.php +2 −2 Go to diff View file
M plugins/testmanagement/include/TestManagement/REST/v1/ExecutionsResource.class.php +3 −3 Go to diff View file
M plugins/tracker/include/REST/v1/ArtifactsResource.class.php +3 −3 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Artifact.php +27 −27 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/ArtifactsDeletion/ArchiveAndDeleteArtifactTaskBuilder.php +2 −2 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/NewChangesetCreator.php +3 −3 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/ActionsQueuer.php +83 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/ActionsRunner.php +11 −47 Go to diff View file
A plugins/tracker/include/Tracker/Artifact/Changeset/PostCreation/PostCreationActionsQueuer.php +30 −0 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_Artifact_Changeset.class.php +4 −4 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/Tracker_Artifact_Changeset_Null.class.php +1 −1 Go to diff View file
M plugins/tracker/include/Tracker/Artifact/XMLImportBuilder.class.php +2 −2 Go to diff View file
M plugins/tracker/include/Tracker/Tracker.class.php +7 −2 Go to diff View file
M plugins/tracker/include/trackerPlugin.php +2 −2 Go to diff View file
M plugins/tracker/tests/unit/Builders/TrackerTestBuilder.php +13 −1 Go to diff View file
A plugins/tracker/tests/unit/Stub/Tracker/Artifact/Changeset/PostCreation/PostCreationActionsQueuerStub.php +42 −0 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Artifact/Changeset/NewChangesetCreatorTest.php +79 −90 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Artifact/Changeset/PostCreation/ActionsRunnerTest.php +40 −113 Go to diff View file
M plugins/tracker/tests/unit/Tracker/Artifact/Tracker_ArtifactTest.php +6 −6 Go to diff View file