Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Convert TrackerXmlImportTest into phpunit

Download Browse

part of story #14291 Beautiful tracker creation Why this change? I plan to inject TrackerXmlImportFeedbackCollector as dependency of class (instead of making new in code). The way the simpletests were written was no help to do easilly such thing, and we are migrating all tests to phpunit. I choosed to do the test migration before updaing any code. This legacy code were always testing from `import` method who was painfull to understand and maintain. The better way I found to don't loose my brain and don't remove all tests was to split things we are testing in protected method and do the code and the assertion only on this part. Change-Id: I515dcb4d60f80e681add0fd677e7261839060fb9

+894 −1703
Marie Ange Garnier (marieange) 2020-02-14 14:09
Marie Ange Garnier (marieange) 2020-02-17 09:50
49abb5dc193a3f83829c065a4b38d04f3e33048e
1f5e528cd0cd1aa03f572d38e9fbb883be63859e
git #tuleap/stable/49abb5dc193a3f83829c065a4b38d04f3e33048e

Modified Files

Side by side diff
Inline diff
Name
M plugins/tracker/include/TrackerXmlImport.class.php +289 −190 Go to diff View file
M plugins/tracker/phpunit/Tracker/TrackerXmlImportTest.php +530 −65 Go to diff View file
A plugins/tracker/phpunit/Tracker/_fixtures/EmptyTracker.xml +22 −0 Go to diff View file
A plugins/tracker/phpunit/Tracker/_fixtures/PermissionTracker.xml +27 −0 Go to diff View file
A plugins/tracker/phpunit/Tracker/_fixtures/TrackersList.xml +26 −0 Go to diff View file
D plugins/tracker/tests/TrackerXmlImportTest.php +0 −1095 Go to diff View file
D plugins/tracker/tests/_fixtures/TestTracker-1.xml +0 −353 Go to diff View file