Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Add a bunch of builder to ease test of controllers

Download Browse

Testing controllers can be a pita because of injections and dependencies on hard to build objects. This introduce a bunch of builders to use real objects instead of mocks. By doing so, we avoid introducing logic in tests, tests are more simple to read and focuses on the intend rather than duplicating target code logic. Part of story #14552 User preferences goes Burning Parrot Change-Id: I0f02d1f8370410e9bc866e3fb76aac731903a1c6

+309 −50
Manuel Vacelet (vaceletm) 2020-02-14 17:20
Manuel Vacelet (vaceletm) 2020-02-18 10:48
49f359ca1fe9667165473ff41c165b26636eb8b9
287863a48d824b5887703b88547603a4d2b4f75c
git #tuleap/stable/49f359ca1fe9667165473ff41c165b26636eb8b9

Modified Files

Side by side diff
Inline diff
Name
M src/common/templating/TemplateCache.php +4 −6 Go to diff View file
A src/common/templating/TemplateCacheInterface.php +31 −0 Go to diff View file
M src/common/templating/TemplateRendererFactory.class.php +5 −7 Go to diff View file
M src/common/templating/mustache/MustacheEngine.php +2 −2 Go to diff View file
M src/common/templating/mustache/MustacheRenderer.class.php +3 −3 Go to diff View file
A tests/lib/Builders/HTTPRequestBuilder.php +54 −0 Go to diff View file
A tests/lib/Builders/IncludeAssetsBuilder.php +43 −0 Go to diff View file
A tests/lib/Builders/LayoutBuilder.php +62 −0 Go to diff View file
A tests/lib/Builders/TemplateRendererFactoryBuilder.php +74 −0 Go to diff View file
M tests/lib/Builders/UserTestBuilder.php +7 −2 Go to diff View file
M tests/phpunit/common/User/Account/DisplayKeysTokensControllerTest.php +24 −30 Go to diff View file