Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Prevent usage of mutable REST representations

Download Browse

This contribution enforces with a Psalm plugin that REST representations are marked as 'psalm-immutable'. A few representations might be missed as some annotations are specific to Restler and not understood. It should however not be a big issue as the immutability have a tendency to "contaminate" classes used in a same composition so the classes that have been missed initially can be spotted anyway. If it becomes an actual issue, two solutions can be considered: giving Restler the ability to understand annotations used everywhere else in the PHP world or give Psalm the ability to understand Restler specific annotation via another plugin. Closes request #15111: REST representations should not be mutable Change-Id: If4dd59e1e33cd2c9c27e8323b0f801ff33512b48

+178 −0
Thomas Gerbet (tgerbet) 2020-07-08 23:18
Thomas Gerbet (tgerbet) 2020-08-26 11:56
4ada793332f9d67404f273bd685412496617a390
7ae8cc8fe5d621a939553d0cffcfb652fd03f91c
git #tuleap/stable/4ada793332f9d67404f273bd685412496617a390

Modified Files

Side by side diff
Inline diff
Name
A tests/lib/Psalm/Plugin/NoWritableRESTRepresentation/DoNotAllowWritableRESTRepresentation.php +140 −0 Go to diff View file
A tests/lib/Psalm/Plugin/NoWritableRESTRepresentation/NoMutableRESTRepresentation.php +37 −0 Go to diff View file
M tests/psalm/psalm.xml +1 −0 Go to diff View file