Part of story #28274: Auto select of parents No functional change expected on the artifact link field: - When "Parent" link type is selected, the link-selector dropdown shows the list of possible parents (sorted by project when in Team project context). - Typing in the link-selector filters the list of parents. - When another link type is selected, the link-selector dropdown is empty, you can type artifact ids to search them. - The "placeholder" for the link-selector changes when "Parent" or another link type is selected. Notes: The goal is to simplify the management of the currently selected link and the management of the link-selector dropdown. Previously, we had setup a memory adapter for the selected link type because it needed to be shared between the LinkFieldController and the AutoCompleter. Instead of this, we can pass the Host (LinkField) to the AutoCompleter, which can read the value there directly. LinkField is now the only place where the state of the current link type is maintained. In the same spirit, we can use a hybrids property to store the link-selector dropdown content. Since it has access to the LinkField, the AutoCompleter can just set it directly, and it will take care of updating the link-selector. This makes AutoCompleter completely separated from link-selector (except for types). In the same way, the controller now has no knowledge of the currently selected link type, it just provides the list of possible parents when asked. Please note that there is now a loop in the setters: set controller -> set current_link_type -> get controller In order to break that loop, we let the setter for controller finish its assignment (by letting it return) and later (through setTimeout) we assign current_link_type. As a result, the setCurrentLinkType will find the host.controller and all we be well. Change-Id: I422931e32244ebe9568eb47026f658e2cdc0b54b

+202 −569

Author

Joris MASSON (jmasson) 2022-09-30 10:51

Committer

Joris MASSON (jmasson) 2022-09-30 16:58

Hash 4b90b56c40ac97010de0e8f6e565caae085764d4

Parent f37bb413ffb14f291837ab02d3338a3d2f3bc47b

Reference git #tuleap/stable/4b90b56c40ac97010de0e8f6e565caae085764d4