Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

feat: Prevent browser to leave page during edition

Download Browse

When users start to edit an artidoc, the browser should ask them for confirmation before losing the current changes. The confirmation should be displayed as soon as there is at least one editor open. Took the opportunity to homogeneize the public api of useSectionEditor: instead of having a `cancelEditor()` and a `setEditMode(true)` we now have `cancelEditor()` and `enableEditor()`. Naming is more consistent and the parameter was always true publicly. Part of story #37543: edit Artidoc sections Change-Id: I59c03a79d53cdd1324fa913e9e589e3b9f8c0319

+127 −8
Nicolas Terray (nterray) 2024-05-21 13:53
Nicolas Terray (nterray) 2024-05-23 16:38
4cbfcb6f149cb5752cd45e3a8be51f012a8b1176
8e075b7c0a180d0f02416e22f99642128d1dde1f
git #tuleap/stable/4cbfcb6f149cb5752cd45e3a8be51f012a8b1176

Modified Files

Side by side diff
Inline diff
Name
M plugins/artidoc/scripts/artidoc/src/components/SectionEditorCta.test.ts +1 −1 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/components/SectionEditorCta.vue +2 −2 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/composables/useSectionEditor.test.ts +68 −3 Go to diff View file
M plugins/artidoc/scripts/artidoc/src/composables/useSectionEditor.ts +26 −2 Go to diff View file
A plugins/artidoc/scripts/artidoc/src/helpers/on-before-unload.ts +30 −0 Go to diff View file