stable

Clone or download

Read-only

Fix recent issues spotted by vimeo/psalm in the docman plugin

Most of these issues has been introduced by recent developments for epic #12638 (Docman leverages Burning Parrot) and git #tuleap/stable/cb998005144ae9a82850969dbcf41ad513b0774f. The goal here is to clean errors that has been introduced since the baseline creation before recreating a new baseline with the update of vimeo/psalm. Remaining issues on SoapFault constructors are caused by a bug in the version of Psalm we are currently using [0]. Part of request #13292: Integrate vimeo/psalm to the test pipeline [0] https://github.com/vimeo/psalm/issues/1535 Change-Id: Ie5f710515e63c9136f4fd96f677a9bead60e243c

Modified Files

Name
M plugins/docman/include/ApprovalTable/Link/LinkFactory.class.php +2 −2 Go to diff View file
M plugins/docman/include/ApprovalTable/Reminder.class.php +10 −6 Go to diff View file
M plugins/docman/include/Docman_Actions.class.php +2 −1 Go to diff View file
M plugins/docman/include/Docman_ActionsDeleteVisitor.class.php +15 −11 Go to diff View file
M plugins/docman/include/Docman_CloneItemsVisitor.class.php +13 −11 Go to diff View file
M plugins/docman/include/Docman_ItemDao.class.php +17 −12 Go to diff View file
M plugins/docman/include/Docman_ItemFactory.class.php +1 −0 Go to diff View file
M plugins/docman/include/Docman_LockDao.class.php +2 −2 Go to diff View file
M plugins/docman/include/Docman_LockFactory.class.php +5 −2 Go to diff View file
M plugins/docman/include/Docman_NotificationsManager.class.php +1 −1 Go to diff View file
M plugins/docman/include/Docman_PermissionsManager.class.php +8 −4 Go to diff View file
M plugins/docman/include/Docman_SettingsBo.class.php +2 −1 Go to diff View file
M plugins/docman/include/Docman_VersionDao.class.php +6 −3 Go to diff View file
M plugins/docman/include/Docman_Widget_Embedded.class.php +19 −7 Go to diff View file
M plugins/docman/include/Notifications/NotificationsForProjectMemberCleaner.php +3 −0 Go to diff View file
M plugins/docman/include/REST/v1/DocmanItemCreator.php +2 −2 Go to diff View file
M plugins/docman/include/REST/v1/DocmanLinksResource.php +1 −1 Go to diff View file
M plugins/docman/include/REST/v1/DocmanWikiResource.php +1 −1 Go to diff View file
M plugins/docman/include/REST/v1/Folders/DocmanItemCreatorBuilder.php +1 −1 Go to diff View file
M plugins/docman/include/REST/v1/Metadata/HardcodedMetadataObsolescenceDateRetriever.php +0 −4 Go to diff View file
M plugins/docman/include/REST/v1/Metadata/HardcodedMetadataUsageChecker.php +0 −19 Go to diff View file
M plugins/docman/include/REST/v1/Metadata/ItemStatusMapper.php +14 −12 Go to diff View file
M plugins/docman/include/view/Docman_View_Admin_LockInfos.class.php +16 −14 Go to diff View file
M plugins/docman/include/view/Docman_View_GetMenuItemsVisitor.class.php +11 −11 Go to diff View file
M plugins/docman/include/view/Docman_View_ItemTreeUlVisitor.class.php +15 −8 Go to diff View file
M plugins/docman/phpunit/Metadata/HardcodedMetadataUsageCheckerTest.php +0 −41 Go to diff View file
A plugins/docman/phpunit/Metadata/ItemStatusMapperTest.php +54 −0 Go to diff View file
M src/common/Error/Error_PermissionDenied.class.php +2 −9 Go to diff View file
M src/common/permission/PermissionsManager.class.php +2 −2 Go to diff View file