Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

Remove not needed method \Tuleap\Dao\UserSuspensionDao::verifySuspension

Download Browse

This method is only called after we call UserSuspensionDao::suspendAccount() which makes it useless. Either the query in suspendUser has crashed in which case we will never reach this part of the code or if the query has succedded the only way for this method to return true is a race condition (if we exclude DB issues). Part of story #13811: Have a customisable reactivation period for the account Change-Id: I884d21a6b7667de9c78e4d1015d9a9bf3712a6b3

+4 −23
Thomas Gerbet (tgerbet) 2020-07-21 16:48
Thomas Gerbet (tgerbet) 2020-07-22 19:23
4d7638bbefe510dc2bd805c9c6da575b43a45f79
140779d055112586349b093735acb7ef4ec1513e
git #tuleap/stable/4d7638bbefe510dc2bd805c9c6da575b43a45f79

Modified Files

Side by side diff
Inline diff
Name
M src/common/User/UserSuspensionManager.php +1 −6 Go to diff View file
M src/common/dao/UserSuspensionDao.php +1 −13 Go to diff View file
M tests/unit/common/User/UserSuspensionManagerTest.php +2 −4 Go to diff View file