Public

Project privacy set to public. By default, its content is available to everyone (authenticated or not). Please note that more restrictive permissions might exist on some items.

stable

Clone or download

Read-only

refactor: MappedFieldRetriever returns Option

Download Browse

part of request #39022 Moving a card in Taskboard can have side effects No functional change. Unit and REST tests should pass. Why? This series of refactorings has the goal to make it easy to write a "domain" API to find the current column of a given card. This requires us to know which field in the card's tracker is "mapped" (either freestyle or status semantic). We continue by simplifying the retrieval of the mapped field. Change-Id: I01e618e033f0ad3f96f4108466f91ba855bd8ae0

+491 −408
Joris MASSON (jmasson) 2024-08-22 16:50
Joris MASSON (jmasson) 2024-08-23 15:03
4ec63e6c0cc264ef3cd521970d04f2d81d793db4
8594503d183c88532e0718eff3d2f5d1b64be487
git #tuleap/stable/4ec63e6c0cc264ef3cd521970d04f2d81d793db4

Modified Files

Side by side diff
Inline diff
Name
M plugins/taskboard/include/Column/FieldValuesToColumnMapping/ArtifactMappedFieldValueRetriever.php +23 −30 Go to diff View file
M plugins/taskboard/include/Column/FieldValuesToColumnMapping/Freestyle/FreestyleMappedFieldRetriever.php +9 −6 Go to diff View file
M plugins/taskboard/include/Column/FieldValuesToColumnMapping/MappedFieldRetriever.php +9 −9 Go to diff View file
M plugins/taskboard/include/Column/FieldValuesToColumnMapping/TrackerMappingPresenterBuilder.php +2 −2 Go to diff View file
M plugins/taskboard/include/REST/v1/Cell/CardMappedFieldUpdater.php +14 −16 Go to diff View file
M plugins/taskboard/include/Tracker/TrackerPresenterCollectionBuilder.php +3 −5 Go to diff View file
M plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/ArtifactMappedFieldValueRetrieverTest.php +103 −112 Go to diff View file
M plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/Freestyle/FreestyleMappedFieldRetrieverTest.php +17 −15 Go to diff View file
M plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/Freestyle/SearchMappedFieldStub.php +26 −5 Go to diff View file
M plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/MappedFieldRetrieverTest.php +22 −14 Go to diff View file
M plugins/taskboard/tests/unit/Column/FieldValuesToColumnMapping/TrackerMappingPresenterBuilderTest.php +98 −79 Go to diff View file
M plugins/taskboard/tests/unit/REST/v1/Cell/CardMappedFieldUpdaterTest.php +51 −40 Go to diff View file
M plugins/taskboard/tests/unit/Tracker/TrackerPresenterCollectionBuilderTest.php +97 −70 Go to diff View file
M plugins/tracker/tests/unit/Stub/Tracker/FormElement/Field/ListFields/RetrieveUsedListFieldStub.php +17 −5 Go to diff View file