stable

Clone or download

Read-only

gitlab_commit references are now usable

This is part of story #17180 take into account gitlab commits If you manually add a reference gitlab_commit, they are now usable. If the project previously defined a project reference named gitlab_commit, then the behaviour must be the one defined by the project reference. How does it work? ----------------- * If you provide the reference gitlab_commit #root/project/sha1, the link will be clickable if in the same project of your ressource with this reference there is a GitLab repo named root/project/ integrated. * If you provide the reference gitlab_commit #prjname:root/project/sha1, the link will be clickable if, in the Tuleap project named prjname, there is a GitLab repo named root/project/integrated. Any other case, the reference will not be clickable. Known issues ------------ * With the current reference system, any GitLab repository name and/or path containing any "-" or "." will not be a working reference (not clickable). This must be fixed globally in the Tuleap reference system. Change-Id: Icd1094b26779a2aad2835c6d1ea06b03cc0904ca

Modified Files

Name
A plugins/gitlab/include/Reference/GitlabCommitReference.php +46 −0 Go to diff View file
A plugins/gitlab/include/Reference/GitlabCommitReferenceBuilder.php +92 −0 Go to diff View file
A plugins/gitlab/include/Reference/ReferenceDao.php +41 −0 Go to diff View file
M plugins/gitlab/include/Repository/GitlabRepositoryDao.php +14 −0 Go to diff View file
M plugins/gitlab/include/Repository/GitlabRepositoryFactory.php +10 −0 Go to diff View file
M plugins/gitlab/include/gitlabPlugin.php +60 −3 Go to diff View file
M plugins/gitlab/site-content/fr_FR/LC_MESSAGES/tuleap-gitlab.po +3 −0 Go to diff View file
A plugins/gitlab/tests/unit/Reference/GitlabCommitReferenceBuilderTest.php +170 −0 Go to diff View file