stable

Clone or download

Read-only

feat: Display replies

part of story #29240 reply to pull request comment How to test: - Create a new pull request - Add a global comment - Add an inline comment - Using the REST api, create a reply to those 2 comments - Go back to the pull-request and refresh the app - In the timeline view: --> The global comment has its reply displayed in a thread right below it --> Same for the inline comment, its reply does not display the file name - In the file-diff view, both in side-by-side diff and unidiff mode --> The comment thread is displayed properly Change-Id: I9209357304401e322748de8d52deece6610eacb6

Modified Files

Name
M plugins/pullrequest/scripts/pullrequests-app/package.json +1 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/pnpm-lock.yaml +38 −36 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestComment.test.ts +6 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestComment.ts +32 −8 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentBodyTemplate.test.ts +13 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentBodyTemplate.ts +21 −16 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentController.test.ts +19 −3 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentController.ts +7 −1 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentFooterTemplate.ts +9 −2 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentPresenter.test.ts +1 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentPresenter.ts +5 −0 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentRepliesCollectionPresenter.ts +29 −0 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentRepliesStore.test.ts +122 −0 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentRepliesStore.ts +117 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentReplyFormTemplate.ts +1 −1 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/src/app/comments/PullRequestCommentReplyTemplate.ts +41 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/codemirror-helper-service.js +9 −2 Go to diff View file
R plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/comments-state.js Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/side-by-side-diff-component.js +10 −5 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/diff-modes/unidiff-component.js +14 −9 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/file-diff/file-diff-component.js +2 −2 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/overview/timeline/timeline-controller.js +20 −7 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/overview/timeline/timeline-service.js +7 −3 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/overview/timeline/timeline-service.test.js +13 −6 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/src/app/overview/timeline/timeline.tpl.html +1 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/tests/stubs/PullRequestCommentControllerStub.ts +1 −0 Go to diff View file
M plugins/pullrequest/scripts/pullrequests-app/tests/stubs/PullRequestCommentPresenterStub.ts +7 −0 Go to diff View file
A plugins/pullrequest/scripts/pullrequests-app/tests/stubs/StorePullRequestCommentRepliesStub.ts +58 −0 Go to diff View file
M plugins/pullrequest/themes/includes/_tuleap-pullrequest-comment.scss +16 −2 Go to diff View file